From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48719 invoked by alias); 22 Nov 2016 14:38:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48708 invoked by uid 89); 22 Nov 2016 14:38:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=quoting X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Nov 2016 14:38:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E28294DD79; Tue, 22 Nov 2016 14:38:06 +0000 (UTC) Received: from localhost.localdomain (vpn1-5-13.ams2.redhat.com [10.36.5.13]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAMEc4jY019406; Tue, 22 Nov 2016 09:38:05 -0500 Subject: Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function To: Jakub Jelinek References: <43d4ec20-5f84-2533-22e4-e16c779f6162@redhat.com> <1476304646-39819-1-git-send-email-dmalcolm@redhat.com> <20161122131836.GA7025@linux.vnet.ibm.com> <48811c08-6412-2e8b-2763-b163c358afe3@redhat.com> <20161122133750.GR3541@tucnak.redhat.com> Cc: vogt@linux.vnet.ibm.com, David Malcolm , gcc-patches@gcc.gnu.org From: Bernd Schmidt Message-ID: Date: Tue, 22 Nov 2016 14:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161122133750.GR3541@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg02218.txt.bz2 On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > Can't it be done only if xloc.file contains any fancy characters? Sure, but why? Strings generally get emitted with quotes around them, I don't see a good reason for filenames to be different, especially if it makes the output easier to parse. > If it does (where fancy should be anything other than [a-zA-Z/_0-9.-] or > some other reasonable definition, certainly space, quotes, backslash, etc. would count), > shouldn't we adjust it (e.g. use \" instead of ", handle control characters > etc.)? The way I see it, spaces in filenames are regrettably somewhat common. Backslashes and quotes rather less so, to the point I really don't see a need to worry about them at the moment, and the necessary quoting could be added later if really necessary. Bernd