From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id E56283858D37 for ; Mon, 18 Mar 2024 17:35:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E56283858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E56283858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710783320; cv=none; b=QAmfIxkcfyHFyEjcRk8ED1MlN4U40gkfm8oCfC3RWjfjpCEWfBj9QHqsyNZ/uRxg+LKwTCxN6x5ZSM6S9V42DlTxkdWiFoPLlGtDrnfh8Wnlc1cWfTFOUU+DOJLbyEjp1FExjXfRBcgdoGrfBCKo8evLvmJZaoduZruML1G4OHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710783320; c=relaxed/simple; bh=Snask3nkKHNwYbA3q8AONKpf2qVy77JXxnVxsNRZylM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AjJERSOWNqXhBboBnF/0ng1brP9JYEX2tViWOrAMqod8KI9WyC5D+bAfI55O8wZbxRdgcjw38Z/PI4EoWgf0zauwijDJJuv0rSRyvWZokKlM6UdAyrdeWR0YFnGpTb/bJBo4eJqWVnJ6bhKvSl042lyiEzCW5enDECm5Xm65mgQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42IGekcx027385; Mon, 18 Mar 2024 17:35:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=TgHAlhYcTni0F88R+L6PbG7J+wstMoIM2/1S/8iwc8I=; b=l8m7WHFBUVtjYARyFOPhZax6oAvVgRB/tku+Z2cT7RHAOFyKoYxZw2QAlqSrHH3nZUtC 87x1SjZk4w7SP5ykWzWhXjGNkCBlCvDxUbwfrUnIgjLEpBwZHePIduK6yHsuTIY7yWcM Wm3UxG3Ftv7yY2cq/SxVfes2yPo1UNMARR433zFpOGB36Nx1vXRyap5F/KaJe8YPJYdU PkGsC1bJoPOOU3cdHGQ1Jsxawk5Jv/L2fffP0OzstfrW+IoBt19dxOpmKyS7QOQil1tb k+YIlWZVwEcDmPCFajZ3/Afu8qoGg3GC2u2c6ywnXp342f39RgSCBWL35TXy3x3uOSD3 dQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wxs540e61-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Mar 2024 17:35:15 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42IHVtQB015801; Mon, 18 Mar 2024 17:35:14 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wwp4ytgre-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Mar 2024 17:35:14 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42IHZAPu34996620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Mar 2024 17:35:13 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C33235804B; Mon, 18 Mar 2024 17:35:10 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B80E5806D; Mon, 18 Mar 2024 17:35:10 +0000 (GMT) Received: from [9.61.153.201] (unknown [9.61.153.201]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 18 Mar 2024 17:35:10 +0000 (GMT) Message-ID: Date: Mon, 18 Mar 2024 12:35:09 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000: Fix issue in specifying PTImode as an attribute [PR106895] Content-Language: en-US To: Segher Boessenkool , P Jeevitha Cc: GCC Patches , "Kewen.Lin" References: <9ea38d87-180f-46b5-a723-45061680980f@linux.vnet.ibm.com> <92507c51-9ff0-4e67-8a6c-7ffb58bc8537@linux.vnet.ibm.com> <20240318143609.GX19790@gate.crashing.org> From: Peter Bergner In-Reply-To: <20240318143609.GX19790@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GvPJD1Qvi9TJQXWjZKnWHt-p8VTjP4A8 X-Proofpoint-ORIG-GUID: GvPJD1Qvi9TJQXWjZKnWHt-p8VTjP4A8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-18_12,2024-03-18_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=904 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403140000 definitions=main-2403180132 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/18/24 9:36 AM, Segher Boessenkool wrote: > Hi! > > On Fri, Feb 23, 2024 at 03:04:13PM +0530, jeevitha wrote: >> PTImode attribute assists in generating even/odd register pairs on 128 bits. > > It is a mode, not an attribute. Attributes are on declarations, while > modes are on a much more fundamental level (every value has a mode, in > GCC!) > >> When the user specifies PTImode as an attribute, it breaks because there is no >> internal type to handle this mode . We have created a tree node with dummy type >> to handle PTImode. > > You are talking about the mode attribute. Aha. Correct. >> We are not documenting this dummy type since users are not >> allowed to use this type externally. > > Not sure what this is meant to mean? What does "allowed to" mean, even? > We do not forbid people from doing anything (we can discourage them > though). Or dso you mean something just doesn't work? The use case is the Linux kernel will use the mode attribute as shown in the test case. The type she created was needed for the code to "work" internally, but we don't want to advertise it to users, so that's why we're not documenting it. Yes, pesky users who go digging through the GCC source could find it and use it, but we don't want to encourage them. :-) >> PR target/106895 >> * config/rs6000/rs6000.h (enum rs6000_builtin_type_index): Add fields >> to hold PTImode type. > > An enum does not have fields. What do you actually mean? Yeah, as per your follow-on comment, I think a simple "Add RS6000_BTI_INTPTI." should suffice. Peter