From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7BAFD3849ACF for ; Fri, 19 Apr 2024 20:40:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BAFD3849ACF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BAFD3849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713559245; cv=none; b=WvwJN0iXRLU7BqZ3bN47tlr/1Vhr2N2Nu7nQDY7hAIIY9A84G3GFTrEd5zbUOJZNCUIT8qNC/mGF4IQGpu8DdFLA43JrOEfaAKBZ8HsUrWL94YoU0YyNJChMPnwiBfh/1k0X5252DZgPG+LxeWzaF6z2y2jHCTqiFSyGsQ2kmvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713559245; c=relaxed/simple; bh=Kf0SIzxjeeGGFgMUhR5TPl6+2FIl85J5aZ7mpdmmqBY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=BciI23QNRyN1Nbmw1VixEXk3KeI7Cq1lD/OTnUN5SRP5bSFRVtcW2YXC3yY48itLehwsSnMxS6YOK/hnli+7J0G+T32A4rYOa7tENBScpzsO/u1sEOH+hVC9KdR38WtXLu9Q3hDL9Aqlpyoy5LI+GGG3SanSNR6ct4QsSI495Ks= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713559244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HeDsbF02It5u0nRMhWT6ii7p/7E6Gg4R4WyjimVgbrY=; b=DmDAUbFfQzrF1C0kdjcRnB2m9nx2oeTZv6mAwhfJ4xAfF1yn41B2GE/O3+Y6LIDbcm016i AYLCcnfn/U/boEZtw5WcBmaNlDPefLyM+EQIKaaidcvlr56oG1EQ6PMKDrWbEt0ZloaKex UfI2XJcCrkdTZAwTleisKqIVtO344Cw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-3cMJsb3DOyuAM0_CHZ6PQw-1; Fri, 19 Apr 2024 16:40:40 -0400 X-MC-Unique: 3cMJsb3DOyuAM0_CHZ6PQw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4183d08093bso14298225e9.1 for ; Fri, 19 Apr 2024 13:40:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713559239; x=1714164039; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HeDsbF02It5u0nRMhWT6ii7p/7E6Gg4R4WyjimVgbrY=; b=qggdHsaDk83LUanBZEOVTV5KajVXbjCbhatx0g3M4ZG0FOv2Xl5oQlFvwwkjKMiiCG 46wpszH0vu+QL3+ZmLbxVF304doXHtLHp84CVf806VLM3Xo1h8vg9FB3KquUkZJuVT0f AS0q6YcYIYFYiKVKzhobDVzW9TXLCLt12SFytUeIv8DvD+nhGaQjyOJAL6afzj6QpfXC ekvD92b76CAaeFIWZT2TI9fmv2sgUlpeVOBIqK45bWPG2jyzMyWwMDYytKFQSS3PaYoi K5XU7Qr1AJwjpKscTDMaM11rHoqhgjPdd5ZjnAYIig2qzKxE44ie3CKzV2nnjoDZhhBI qNZQ== X-Forwarded-Encrypted: i=1; AJvYcCWSh5CKW8q2+gTo6zP5zpulKZNJSgKk//2kePm3ZNhcxtJc6fR32/f+jXuD9jE6REsZRFWXwzAW3WG7rso/qicu+hWMtTGXiQ== X-Gm-Message-State: AOJu0Yy9xpDioLO0uPyRadnpbIue3BWDTdZ+J0qoUCMekCLfivg+7rxz yJa+ItwlXCWGvb9oEGePp86ec7VJGW3TNBK7K+Rne3u9KyKDJPY1oMZ68pZYJGaQfpMMRr7Gn6g 1IIRra3NVRUmG59k/sFG/LqIw2Eem4ugV57ug2d80ohYt6lkpAUzghOo= X-Received: by 2002:a05:600c:4e8b:b0:418:b74f:5a4f with SMTP id f11-20020a05600c4e8b00b00418b74f5a4fmr2662138wmq.9.1713559239292; Fri, 19 Apr 2024 13:40:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGON5JH8Ng6Jf66bEVD0CCNX0rVkqXua34CQAgPpGSzU2idpMZLPh/rvWBWhjGri7UA/8DoOA== X-Received: by 2002:a05:600c:4e8b:b0:418:b74f:5a4f with SMTP id f11-20020a05600c4e8b00b00418b74f5a4fmr2662132wmq.9.1713559238930; Fri, 19 Apr 2024 13:40:38 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id e15-20020a05600c218f00b004146e58cc35sm11175465wme.46.2024.04.19.13.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 13:40:37 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rxv0x-000GBI-2Z; Fri, 19 Apr 2024 20:39:19 +0000 Date: Fri, 19 Apr 2024 20:39:19 +0000 (UTC) From: Joseph Myers To: Jakub Jelinek cc: Richard Biener , Martin Uecker , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] c, v3: Fix ICE with -g and -std=c23 related to incomplete types [PR114361] In-Reply-To: Message-ID: References: <02a9b94e4d653b6f1b9f89a1b62187f46e871738.camel@tugraz.at> <448b0744f89d5c6ba5d6a5bacda154fcb74b7bca.camel@tugraz.at> <71q844s1-p7ps-492r-qp8r-r8nq69s8qp8n@fhfr.qr> <00r63o4n-88ns-0184-n594-55n69769n785@fhfr.qr> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Apr 2024, Jakub Jelinek wrote: > 2024-04-15 Martin Uecker > Jakub Jelinek > > PR lto/114574 > PR c/114361 > gcc/c/ > * c-decl.cc (shadow_tag_warned): For flag_isoc23 and code not > ENUMERAL_TYPE use SET_TYPE_STRUCTURAL_EQUALITY. > (parser_xref_tag): Likewise. > (start_struct): For flag_isoc23 use SET_TYPE_STRUCTURAL_EQUALITY. > (c_update_type_canonical): New function. > (finish_struct): Put NULL as second == operand rather than first. > Assert TYPE_STRUCTURAL_EQUALITY_P. Call c_update_type_canonical. > * c-typeck.cc (composite_type_internal): Use > SET_TYPE_STRUCTURAL_EQUALITY. Formatting fix. > gcc/testsuite/ > * gcc.dg/pr114574-1.c: New test. > * gcc.dg/pr114574-2.c: New test. > * gcc.dg/pr114361.c: New test. > * gcc.dg/c23-tag-incomplete-1.c: New test. > * gcc.dg/c23-tag-incomplete-2.c: New test. OK. -- Joseph S. Myers josmyers@redhat.com