From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 5D6333858C35 for ; Mon, 18 Dec 2023 15:39:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D6333858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5D6333858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702913990; cv=none; b=DWMFUBbBMT6gihkFcI4fh5OHqRQDBoPRtYketnupFt+EcXIedT73OZFCg6euu8BWive+2sXjom66+ey9pC8uZU29qfcDIWPXL+A0GaV1i5wFcrzs50BsWn2En6ReraPfWqf7e2nILhY5xc7xlPVJk63bon6ZoPjSpG9zyjZBzqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702913990; c=relaxed/simple; bh=6nmvXcBqR/M2DOIfeEHcyYXYhJBuj5L7ugdffZ957+8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EFqRibqOtU8p8OtQ3cHOuN+kYQNEO38QsL//fWJZzaBtT7P5rRnKHCPIUUeQACrHoUZSuqU5MqFVI54qqpWca8vrg30E8QSEA64AZ4ANmZenG+KbIEjJ+GG51JlYUrCm8LJHUTzXJhTOdwxPVwU1rXtYQx7FJgGezDiPY89FhfY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1d3b4b803f4so5253425ad.1 for ; Mon, 18 Dec 2023 07:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702913988; x=1703518788; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eGCn2pc7qyhE2gGdxWXswkGBgMOPW+9HrVbhnPG1O2Q=; b=LSVpdtDZVHqYHbTZNkF5if32p5SI8x67VePdSh+zrAzcpg+zxMQlUEKTeEnXRLqklW tf+10kZP3agKAOTZfQRHlJ2eVsZNeElb6dGV72bHqIsfsYDxHWuyNJKqSdria8UYDU2+ lnkGujB4TLvBL7ogvzP2dSGOL+7YrylwdNX8uo8ttJ031UaRvY6LNAfdMQXCKqloB8HF IIV1BHawwCGfpB3Yofe2Hmu95WrBk99XPMmqnQOh6kJ1AUJLZBRUNGx6tMFuoNjxJsZD dDYeI6w9PMBexQ3ENiNWjGoZPTrTjhSvXxxDk1h7m170Nzyx8lEGDNly/SDPNiqDA3bV YcZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702913988; x=1703518788; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eGCn2pc7qyhE2gGdxWXswkGBgMOPW+9HrVbhnPG1O2Q=; b=jMHCAVTBeHoAXZ+2P5qtYHJ/YiQtjmXVccpeAmVHMpjMpwXjKqw2ovnWeU6x1Do3m/ mDCJ0xg6bUAL/O+4O5C7n0JCSSoaTofIj5E0UgVnULyHjuh/kDYT47a2v5Wl12Cpi7qp AGYogkBFyy6qPOrtPZ0w6oFfMgLaExkqG83f1YwkEpM0n91heDvVO/5E/6/UAMXxI3Yh y1UC2aQIXDA5/L7zfeod0wb1JFNtb4nm0m20NJOnp4smafPVH1RkptoqdfVaKgRxV2Lc eWCHHkF4i9ySUqaJ16UwwtldBaVs0/PimcvyEmv1e440GPLIvCrgTpEX8jaoqXFf6C7o Ldew== X-Gm-Message-State: AOJu0YwdLwOMR4vU20RXZ1U869PIH977GF/MWbd4fwfFa2nWB5SuHgTq l3Jhuln2ZljnvQcwNF1vuR0= X-Google-Smtp-Source: AGHT+IH6n8xsPwERhVMOJ29zLjR9KWgtJ+lMDaXGqJosWUHvOveoA5eI3cxJ+P5v5arF1q1gFvP0xg== X-Received: by 2002:a17:903:1248:b0:1d3:ad3d:2bec with SMTP id u8-20020a170903124800b001d3ad3d2becmr906872plh.25.1702913987524; Mon, 18 Dec 2023 07:39:47 -0800 (PST) Received: from [172.31.1.103] ([172.56.168.60]) by smtp.gmail.com with ESMTPSA id ba1-20020a170902720100b001d09c539c95sm19288544plb.90.2023.12.18.07.39.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 07:39:45 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 08:39:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] middle-end: Call negate_rtx instead of simplify_gen_unary expanding rotate shift [PR113033] Content-Language: en-US To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , chenglulu , i@xen0n.name, xuchenghua@loongson.cn, c@jia.je References: <20231218134251.1513432-1-xry111@xry111.site> From: Jeff Law In-Reply-To: <20231218134251.1513432-1-xry111@xry111.site> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/18/23 06:42, Xi Ruoyao wrote: > With simplify_gen_unary we end up with a not fully expanded RTX like > > (set (reg:SI 90) (and:SI (neg:SI (reg:SI 80)) (const_int 63))) > > Then it will cause an ICE with unrecognizable insn. > > gcc/ChangeLog: > > PR middle-end/113033 > * expmed.cc (expand_shift_1): When expanding rotate shift, call > negate_rtx instead of simplify_gen_unary (NEG, ...). The key difference being that using negate_rtx will go through the expander which knows how to synthesize negation whereas simplify_gen_unary will just generate a (neg ...) and assume it matches something in the backend, right? If so, this patch is fine for the trunk. jeff