From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 1313D385C41C for ; Thu, 25 Aug 2022 08:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1313D385C41C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxReL7Mgdjnp4JAA--.43105S2; Thu, 25 Aug 2022 16:29:47 +0800 (CST) Subject: Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: Chenghua Xu , Youling Tang , Huacai Chen , Jinyang He , Wang Xuerui References: From: Lulu Cheng Message-ID: Date: Thu, 25 Aug 2022 16:29:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: AQAAf8DxReL7Mgdjnp4JAA--.43105S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZrW3Zr1xCr43Xr15Cry8Zrb_yoWxuFX_KF s5JF12yFs7Gr4Sqr4qyFW0qF48Jw1fCFy5Xrs5tF92934ktwnxGF1DZw13Zr45A395ur4a grWxXFW8ZrWxAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxkFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E 87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjI I2zVCS5cI20VAGYxC7Mx8GjcxK6IxK0xIIj40E5I8CrwCYjI0SjxkI62AI1cAE67vIY487 MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_ Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VU1 g4S7UUUUU== X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, HTML_MESSAGE, KAM_DMARC_STATUS, KAM_STOCKGEN, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2022 08:29:54 -0000 在 2022/8/24 下午10:03, Xi Ruoyao 写道: > SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS > invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. > > r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking > "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possible that "x" > is not a SYMBOL_REF. So we need to check if "x" is SYMBOL_REF first. > > This fixes a test failure happening with r13-2173: > > pr106096.C:26:1: internal compiler error: RTL flag check: > SYMBOL_REF_FLAGS used with unexpected rtx code 'const' in > loongarch_classify_symbol I think there is no problem with the code modification, but I have not detected this ICE. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 1313D385C41C for ; Thu, 25 Aug 2022 08:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1313D385C41C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxReL7Mgdjnp4JAA--.43105S2; Thu, 25 Aug 2022 16:29:47 +0800 (CST) Subject: Re: [PATCH 1/2] LoongArch: Avoid RTL flag check failure in loongarch_classify_symbol To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: Chenghua Xu , Youling Tang , Huacai Chen , Jinyang He , Wang Xuerui References: From: Lulu Cheng Message-ID: Date: Thu, 25 Aug 2022 16:29:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------7D6D7EF9AB30651EBE29341B" Content-Language: en-US X-CM-TRANSID:AQAAf8DxReL7Mgdjnp4JAA--.43105S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZrW3Zr1xCr43Xr15Cry8Zrb_yoWxuFX_KF s5JF12yFs7Gr4Sqr4qyFW0qF48Jw1fCFy5Xrs5tF92934ktwnxGF1DZw13Zr45A395ur4a grWxXFW8ZrWxAjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxkFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E 87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjI I2zVCS5cI20VAGYxC7Mx8GjcxK6IxK0xIIj40E5I8CrwCYjI0SjxkI62AI1cAE67vIY487 MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_ Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7VU1 g4S7UUUUU== X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,HTML_MESSAGE,KAM_DMARC_STATUS,KAM_STOCKGEN,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20220825082947.wsyJg6qQUTzs0YoAxwfskVGv-n0F8k4iQKH7PQYrRBE@z> This is a multi-part message in MIME format. --------------7D6D7EF9AB30651EBE29341B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit 在 2022/8/24 下午10:03, Xi Ruoyao 写道: > SYMBOL_REF_TLS_MODEL invokes SYMBOL_REF_FLAGS, and SYMBOL_REF_FLAGS > invokes RTL_FLAG_CHECK1 and aborts when RTL code is not SYMBOL_REF. > > r13-1833 removed "gcc_assert (SYMBOL_REF_P (x))" before invoking > "SYMBOL_REF_TLS_MODEL (x)", indicating that it's now possible that "x" > is not a SYMBOL_REF. So we need to check if "x" is SYMBOL_REF first. > > This fixes a test failure happening with r13-2173: > > pr106096.C:26:1: internal compiler error: RTL flag check: > SYMBOL_REF_FLAGS used with unexpected rtx code 'const' in > loongarch_classify_symbol I think there is no problem with the code modification, but I have not detected this ICE. --------------7D6D7EF9AB30651EBE29341B--