From: Toon Moene <toon@moene.org>
To: sgk@troutmask.apl.washington.edu
Cc: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH 1/2] analyzer: gfortran testsuite support
Date: Sun, 09 Feb 2020 21:37:00 -0000 [thread overview]
Message-ID: <a5106716-71a1-477f-74aa-a2b6e8c41c44@moene.org> (raw)
In-Reply-To: <20200209205511.GA63077@troutmask.apl.washington.edu>
On 2/9/20 9:55 PM, Steve Kargl wrote:
> On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote:
>> On 2/6/20 9:01 PM, David Malcolm wrote:
>>
>>> PR analyzer/93405 reports an ICE when attempting to use -fanalyzer on
>>> certain gfortran code. The second patch in this kit fixes that, but
>>> in the meantime I need somewhere to put regression tests for -fanalyzer
>>> with gfortran.
>>>
>>> This patch adds a gfortran.dg/analyzer subdirectory with an analyzer.exp,
>>> setting DEFAULT_FFLAGS on the tests run within it.
>>
>> I have seen no objections against this proposal, so please go ahead.
>>
>
> Perhaps, there are no objections because the people who contribute
> patches and provide reviews for gfortran have twindled to 1 or 2 people
> with sporadic available time. Did you actually review the proposed
> changes?
You are right. I did test the fix for PR93405, and thought this update
was included in that test, but it was not - my fault.
I will be more careful in the future about what I test, and show the
results (otherwise, why test ...).
Suggestion withdrawn.
--
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG Maartensdijk, The Netherlands
At home: http://moene.org/~toon/; weather: http://moene.org/~hirlam/
Progress of GNU Fortran: http://gcc.gnu.org/wiki/GFortran#news
prev parent reply other threads:[~2020-02-09 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 20:02 David Malcolm
2020-02-06 20:01 ` [PATCH 2/2] analyzer: fix ICE with fortran constant arguments (PR 93405) David Malcolm
2020-02-09 20:16 ` [PATCH 1/2] analyzer: gfortran testsuite support Toon Moene
2020-02-09 20:55 ` Steve Kargl
2020-02-09 21:19 ` David Malcolm
2020-02-10 0:38 ` Steve Kargl
2020-02-10 20:52 ` David Malcolm
2020-02-10 20:57 ` Steve Kargl
2020-02-09 21:37 ` Toon Moene [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5106716-71a1-477f-74aa-a2b6e8c41c44@moene.org \
--to=toon@moene.org \
--cc=dmalcolm@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).