From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118817 invoked by alias); 9 Feb 2020 21:37:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118795 invoked by uid 89); 9 Feb 2020 21:37:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,KAM_SHORT autolearn=ham version=3.3.1 spammy=withdrawn, phone X-HELO: moene.org Received: from moene.org (HELO moene.org) (80.101.130.238) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Feb 2020 21:37:28 +0000 Received: from localhost ([127.0.0.1] helo=moene.org) by moene.org with esmtp (Exim 4.93) (envelope-from ) id 1j0uGa-007zRt-TL; Sun, 09 Feb 2020 22:37:24 +0100 Subject: Re: [PATCH 1/2] analyzer: gfortran testsuite support To: sgk@troutmask.apl.washington.edu Cc: David Malcolm , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org References: <20200206200144.14304-1-dmalcolm@redhat.com> <3fff5fee-8ac0-b3d1-f7cc-b0a2fb7f2754@moene.org> <20200209205511.GA63077@troutmask.apl.washington.edu> From: Toon Moene Message-ID: Date: Sun, 09 Feb 2020 21:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200209205511.GA63077@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00507.txt.bz2 On 2/9/20 9:55 PM, Steve Kargl wrote: > On Sun, Feb 09, 2020 at 09:15:46PM +0100, Toon Moene wrote: >> On 2/6/20 9:01 PM, David Malcolm wrote: >> >>> PR analyzer/93405 reports an ICE when attempting to use -fanalyzer on >>> certain gfortran code. The second patch in this kit fixes that, but >>> in the meantime I need somewhere to put regression tests for -fanalyzer >>> with gfortran. >>> >>> This patch adds a gfortran.dg/analyzer subdirectory with an analyzer.exp, >>> setting DEFAULT_FFLAGS on the tests run within it. >> >> I have seen no objections against this proposal, so please go ahead. >> > > Perhaps, there are no objections because the people who contribute > patches and provide reviews for gfortran have twindled to 1 or 2 people > with sporadic available time. Did you actually review the proposed > changes? You are right. I did test the fix for PR93405, and thought this update was included in that test, but it was not - my fault. I will be more careful in the future about what I test, and show the results (otherwise, why test ...). Suggestion withdrawn. -- Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290 Saturnushof 14, 3738 XG Maartensdijk, The Netherlands At home: http://moene.org/~toon/; weather: http://moene.org/~hirlam/ Progress of GNU Fortran: http://gcc.gnu.org/wiki/GFortran#news