From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id F39CA3858D28 for ; Tue, 1 Aug 2023 19:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F39CA3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 371JBlbx015605; Tue, 1 Aug 2023 19:19:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Xpx3/npJKLcfkdJqnaCWMpsQPEpUdWg47NNWVDphF0s=; b=FrzWcbKlwRtD0SqD5cmz70oqllkNXxxR6O5u6bBgEJpljIDllWycuCWaGO0feJd+1ceH C6jVpbD5wPF+lDl1MzUQcBJNb1OpdOYzSk6KB0lYpmjK8pJNJyK9dJjJw5bJoFDG/2ed YtMKCauFubZrLDOc03ZWylkrTUsbC/gEfiXQV1hEcR1rVY0rNr3gc2xMVHFeN52sScS4 Q6rPKu11/7LOuheHFyZVIJzOTiByCo4Qf33dsOspVUokfjxepW3TEScj9Rx4CGFwybKV FAY7SGnKWqSlwkz8x33MzTAae88GxInG0NDZ4eB+0RkVbyUtwAmHr5gZTBtnh1dlO6PD JQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s77rtggew-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Aug 2023 19:19:56 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 371JF7r3030738; Tue, 1 Aug 2023 19:19:56 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s77rtggeq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Aug 2023 19:19:56 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 371HJCN4017079; Tue, 1 Aug 2023 19:19:55 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3s5dfy6sm4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Aug 2023 19:19:55 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 371JJsh02360022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Aug 2023 19:19:54 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D92E5805B; Tue, 1 Aug 2023 19:19:54 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B4CAE58059; Tue, 1 Aug 2023 19:19:53 +0000 (GMT) Received: from [9.67.100.2] (unknown [9.67.100.2]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Tue, 1 Aug 2023 19:19:53 +0000 (GMT) Message-ID: Date: Tue, 1 Aug 2023 14:19:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: PING ^2: [PATCH V4, rs6000] Disable generation of scalar modulo instructions To: GCC Patches , Segher Boessenkool , "Kewen.Lin" , Peter Bergner , David Edelsohn References: <57a342c8-c3ae-b12b-f73a-9dc428acc91e@linux.ibm.com> Content-Language: en-US From: Pat Haugen In-Reply-To: <57a342c8-c3ae-b12b-f73a-9dc428acc91e@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JVzXrN5_W4eSCgixZyehtmMRJjhQ6tD3 X-Proofpoint-GUID: iDwg_EbbNAph5Io7CLL9RuQ-HRhbqwUC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-01_16,2023-08-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308010171 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SCC_BODY_URI_ONLY,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/30/23 2:26 PM, Pat Haugen via Gcc-patches wrote: > Updated from prior version to address latest review comment (simplify > umod3). > > Disable generation of scalar modulo instructions. > > It was recently discovered that the scalar modulo instructions can suffer > noticeable performance issues for certain input values. This patch disables > their generation since the equivalent div/mul/sub sequence does not suffer > the same problem. > > Bootstrapped and regression tested on powerpc64/powerpc64le. > Ok for master and backports after burn in? > > -Pat > > > 2023-06-30  Pat Haugen  > > gcc/ >     * config/rs6000/rs6000.cc (rs6000_rtx_costs): Check if disabling >     scalar modulo. >     * config/rs6000/rs6000.h (RS6000_DISABLE_SCALAR_MODULO): New. >     * config/rs6000/rs6000.md (mod3, *mod3): Disable. >     (define_expand umod3): New. >     (define_insn umod3): Rename to *umod3 and disable. >     (umodti3, modti3): Disable. > > gcc/testsuite/ >     * gcc.target/powerpc/clone1.c: Add xfails. >     * gcc.target/powerpc/clone3.c: Likewise. >     * gcc.target/powerpc/mod-1.c: Update scan strings and add xfails. >     * gcc.target/powerpc/mod-2.c: Likewise. >     * gcc.target/powerpc/p10-vdivq-vmodq.c: Add xfails.