From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 4192F3858D1E for ; Wed, 1 Nov 2023 18:53:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4192F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4192F3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698864840; cv=none; b=t8bDvlPLLlWJgpr6ySqkQZal5SYZYDsvfvmZGxrbb3vKwDblRqcrZIvClR/uGd19NNeqUFZnL/cZKqM3l468DCYFRONXWVGsBEu01B3dtOjHtjwbKPPZM0lj/e6e8178F7ITDR3vv0+FZ8xOhBIiLkBBaua/fhkHtPZ6SbQMQp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698864840; c=relaxed/simple; bh=+0y8n5xlabXTO7nf6SByM/+lE+7aXiqXDNl8KYqPOOw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=VaPhf55h4UgVMUHevsF4rguvtjgKrHcSrfq/FJ5Dhv2S84laORXaztX+e6o1h50V44ce80MR0bX5sjC6/Wk67rF0a8CgQaJGXu0zM7BTH/Y0rYwyKp04M1e9mBKKm/iu1Sy+YrQdrGa27wjz4GE/slGjFD7PuCgLIgcDgVJzHrI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5ac865d1358so67211a12.3 for ; Wed, 01 Nov 2023 11:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698864828; x=1699469628; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KsdZkXdqvhuqDLDczo22cKC0uYIPM5pda3zilNZw/SE=; b=ZBZCfaFizEUxWDmFOy8q0Ua1WB+6v1IHLEXmzWwK7SobYAXVV7otnJtyaI5f2Bmm6S pqkoV1iCOuiXo922u6xdw2GV1ltbkc4hbIJTqmtuP+Rl4qT0Cpi8sN6UCXSCDf3+xXSB yFy4F+KSkPi8AFmg43KgvNUdvbvVye5s+VAehh6rGwamuySsOTZl7bSBBhgcIfhAw9az V524Kku7qxEPaTlGju/9SDmD0VyKB2IVcfBdV2bOAHnOPPM+Rf7RebuL+jeo0AxXTuY2 FBLOuCr4Mkc+081VkKw89Zr7DNsrJbSS0DYP+u2r14OXkRltQUJIwv2oizsVoK42nVle vvCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698864828; x=1699469628; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KsdZkXdqvhuqDLDczo22cKC0uYIPM5pda3zilNZw/SE=; b=DjPJCFCehwxIV09UTeqhf/6xCOoQ3CzrG6vnFvQ1aaLmV0x/p3+464lIkrUgwUBY0O y3/8TW1Jj9qGiT/5dpJ5Ayo39SoSRmi+zQUAFze1pCk9DbIkVJCvauer2G4P80Hx0MFe /bfNZNB1TE8WMU1xEZeDUNe/SDiqCVWC6j12TlF4gEeyqZeC5cAjCpqGEIvBeDsjdmD8 +1nSPQlGER/OsZhp+gNUycyqQdRaaPiuJ5ArwHOgeu4mVf77gBNxyfAC6wXXMv1egfoq YCLJfhy2IuyYokQui2X7hk4zWdYaaeSyOBekiIOMFllSN0/1lg/XmZrYnJVPlmjiztyc 4+lw== X-Gm-Message-State: AOJu0YysfqEdbF9rwiFk273bLMlFbHTVwusrw5LfQ7EDvHaRlADrym91 Kaz5KXtra/tynYhPCdMZjqk= X-Google-Smtp-Source: AGHT+IGFAepApNEwI82/z9StY/bm+mc08j92e1dta8ZU5JLG6NPRnM1AM/bGW/A/asjB3oFxIp3gZA== X-Received: by 2002:a05:6a20:7486:b0:140:c838:2b2e with SMTP id p6-20020a056a20748600b00140c8382b2emr14946044pzd.22.1698864827943; Wed, 01 Nov 2023 11:53:47 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id o1-20020a056a0015c100b0068fb783d0c6sm1609715pfu.141.2023.11.01.11.53.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Nov 2023 11:53:47 -0700 (PDT) Message-ID: Date: Wed, 1 Nov 2023 12:53:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Add check for types without insn reservations Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20231101181713.54765-1-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20231101181713.54765-1-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/1/23 12:17, Edwin Lu wrote: > Now that all insns are guaranteed to have a type, ensure every insn > is associated with a cpu unit/insn reservation. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_sched_variable_issue): add disabled assert OK. Really interested to see how often this trips in practice. I suspect often right now ;-) jeff >