From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 436AB3858D34; Tue, 2 Jun 2020 06:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 436AB3858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mliska@suse.cz X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 51BBBAC12; Tue, 2 Jun 2020 06:44:31 +0000 (UTC) Subject: Re: [IMPORTANT] ChangeLog related changes To: Jonathan Wakely , Jakub Jelinek Cc: "gcc@gcc.gnu.org" , gcc-patches References: <20200525224858.GO8462@tucnak> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: Date: Tue, 2 Jun 2020 08:44:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 06:44:31 -0000 On 6/1/20 7:24 PM, Jonathan Wakely wrote: > On Mon, 25 May 2020 at 23:50, Jakub Jelinek via Gcc wrote: >> >> Hi! >> >> I've turned the strict mode of Martin Liška's hook changes, >> which means that from now on no commits to the trunk or release branches >> should be changing any ChangeLog files together with the other files, >> ChangeLog entry should be solely in the commit message. >> The DATESTAMP bumping script will be updating the ChangeLog files for you. >> If somebody makes a mistake in that, please wait 24 hours (at least until >> after 00:16 UTC after your commit) so that the script will create the >> ChangeLog entries, and afterwards it can be fixed by adjusting the ChangeLog >> files. But you can only touch the ChangeLog files in that case (and >> shouldn't write a ChangeLog entry for that in the commit message). >> >> If anything goes wrong, please let me, other RMs and Martin Liška know. > > The libstdc++ manual is written in Docbook XML, but we commit both the > XML and generated HTML pages to Git. Sometimes a small XML file can > result in dozens of mechanical changes to the generated HTML files, > which we record in the ChangeLog as: > > * doc/html/*: Regenerated. > > With the new checks we need to name every generated file individually. > > If we add that directory to the ignored_prefixes list, we won't need > to name them. But then the doc/html/* entry will give an error, and > changes to the HTML files can be committed without any ChangeLog > entry. Should we just stop mentioning the HTML in the ChangeLog? > > We could do something like the attached patch, but it seems overkill > for this one special case. > The patch is fine to me. Can you please a pytest for the situation: contrib/gcc-changelog/test_email.py ? Martin