From: Jeff Law <law@redhat.com>
To: Ilya Enkovich <enkovich.gnu@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, vec-tails 07/10] Support loop epilogue combining
Date: Thu, 21 Jul 2016 16:34:00 -0000 [thread overview]
Message-ID: <a5569c53-11a7-e3e2-4e80-de423d8c1a4a@redhat.com> (raw)
In-Reply-To: <CAMbmDYY8bQ6npQeb+8BK1tVcSDOnzRRN9L2UE4tRwaXbEZby0Q@mail.gmail.com>
On 07/21/2016 03:15 AM, Ilya Enkovich wrote:
> In my list I see #1, #4, and #5 are not approved.
So I think Richi wanted to see param control for the new options; Joseph
wanted the new options properly documented in invoke.texi; I had a few
higher level questions which you answered. Your updated patch #1 added
param control and invoke.texi documentation. So IMHO, #1 is approved.
#4 had some whitespace nits and needed some light doc improvements which
you've done. I think the only real implementation issue was computing
costs in a single scan vs restarting the scan. I was OK with the single
scan approach you took -- not sure how strongly Richi feels about
restarting the scan. Seems like Richi needs to chime in on that topic.
I'm hoping to finish reviewing the update to #5 today.
jeff
next prev parent reply other threads:[~2016-07-21 16:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 19:46 Ilya Enkovich
2016-06-15 11:44 ` Richard Biener
2016-06-16 15:41 ` Ilya Enkovich
2016-06-16 15:51 ` Jeff Law
2016-06-16 16:03 ` Ilya Enkovich
2016-06-16 16:54 ` Jeff Law
2016-06-28 13:37 ` Ilya Enkovich
2016-06-28 14:16 ` Ilya Enkovich
2016-07-11 13:39 ` Ilya Enkovich
2016-07-14 22:04 ` Jeff Law
2016-07-20 14:40 ` Ilya Enkovich
2016-07-20 16:24 ` Jeff Law
2016-07-21 9:15 ` Ilya Enkovich
2016-07-21 16:34 ` Jeff Law [this message]
2016-07-22 11:36 ` Richard Biener
2016-07-25 18:01 ` Jeff Law
2016-07-25 18:33 ` Richard Biener
2016-07-25 21:08 ` Jeff Law
2016-07-26 9:57 ` Ilya Enkovich
2016-07-26 11:51 ` Richard Biener
2016-07-26 13:03 ` Ilya Enkovich
2016-07-26 13:05 ` Richard Biener
2016-07-26 15:26 ` Jeff Law
2016-07-26 15:38 ` Ilya Enkovich
2016-08-01 9:09 ` Ilya Enkovich
2016-08-01 16:10 ` Jeff Law
2016-09-02 14:46 ` Yuri Rumyantsev
2016-09-02 16:33 ` Bin.Cheng
2016-09-05 7:39 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5569c53-11a7-e3e2-4e80-de423d8c1a4a@redhat.com \
--to=law@redhat.com \
--cc=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).