From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 54465393C86C for ; Fri, 13 Nov 2020 22:06:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 54465393C86C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-262-mlmVc_2kPJ-OWKtVKxw03g-1; Fri, 13 Nov 2020 17:06:56 -0500 X-MC-Unique: mlmVc_2kPJ-OWKtVKxw03g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4D23F193ECF2; Fri, 13 Nov 2020 22:06:46 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-176.phx2.redhat.com [10.3.112.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB105282FC; Fri, 13 Nov 2020 22:06:45 +0000 (UTC) Subject: Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION} To: Thomas Schwinge , David Malcolm , gcc-patches@gcc.gnu.org References: <1537905614-44303-1-git-send-email-dmalcolm@redhat.com> <87mtzueumz.fsf@euler.schwinge.homeip.net> From: Jeff Law Message-ID: Date: Fri, 13 Nov 2020 15:06:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <87mtzueumz.fsf@euler.schwinge.homeip.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 22:07:00 -0000 On 11/6/20 1:50 AM, Thomas Schwinge wrote: > Hi! > > On 2018-09-25T16:00:14-0400, David Malcolm wrote: >> The patch adds "dg-optimized" and "dg-missed" directives > Another small thing I just noticed: > >> --- a/gcc/testsuite/lib/gcc-dg.exp >> +++ b/gcc/testsuite/lib/gcc-dg.exp >> +# Handle output from -fopt-info for MSG_OPTIMIZED_LOCATIONS: >> +# a successful optimization. >> + >> +proc dg-optimized { args } { >> + # Make this variable available here and to the saved proc. >> + upvar dg-messages dg-messages >> + >> + process-message saved-dg-error "optimized: " "$args" >> +} >> + >> +# Handle output from -fopt-info for MSG_MISSED_OPTIMIZATION: >> +# a missed optimization. >> + >> +proc dg-missed { args } { >> + # Make this variable available here and to the saved proc. >> + upvar dg-messages dg-messages >> + >> + process-message saved-dg-error "missed: " "$args" >> +} > These currently print "(test for *errors*, line [...])". However, these > diagnostics are not actually error diagnostics (fatal, meaning: causes > compilation to fail) but rather warning diagnostics (non-fatal, doesn't > cause compilation to fail). Thus, same as 'dg-message', these should use > 'saved-dg-warning' instead of 'saved-dg-error', which will print: "(test > for *warnings*, line [...])". OK to change that after regression > testing? Yes. jeff