From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 03D483858D37 for ; Sun, 4 Sep 2022 03:22:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03D483858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxnmv6GRRj9LIQAA--.56873S2; Sun, 04 Sep 2022 11:22:34 +0800 (CST) Subject: Re: [PATCH] LoongArch: add -mdirect-extern-access option To: Xi Ruoyao , gcc-patches@gcc.gnu.org, liuzhensong Cc: Wang Xuerui , Chenghua Xu , Huacai Chen References: <20220901105412.42242-1-xry111@xry111.site> From: Lulu Cheng Message-ID: Date: Sun, 4 Sep 2022 11:22:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------B8B6D4E3CB585CFE0BAF535C" Content-Language: en-US X-CM-TRANSID:AQAAf8Bxnmv6GRRj9LIQAA--.56873S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKF1UZrW5Xw18JF4fuF4rZrb_yoW3Xwc_Zw 13AFy2gay7tFWDGaySyr45uFWrWFZxZryUurZFqr4fGrn8ZrWUK393uw13ZF1xZ3s3Wa9x GF4kJr4Yyw429jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_ Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F 4UJwAS0I0E0xvYzxvE52x082IY62kv0487McIj6xIIjxv20xvE14v26r1j6r18McIj6I8E 87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjI I2zVCS5cI20VAGYxC7Mx8GjcxK6IxK0xIIj40E5I8CrwCYjI0SjxkI62AI1cAE67vIY487 MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_ Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0J Up5l8UUUUU= X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------B8B6D4E3CB585CFE0BAF535C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit 在 2022/9/4 上午10:51, Xi Ruoyao 写道: > On Sun, 2022-09-04 at 10:26 +0800, Lulu Cheng wrote: >> If the above modifications are not added, the function call is: >> >>  bl %plt(test1) >> >> now is : >> >>  bl test1 > Regarding "%plt(...)", in the binutils code: > > /* For compatible old asm code. */ > if (0 == strcmp (op_c_str, "plt")) > btype = BFD_RELOC_LARCH_B26; > > Link: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gas/config/loongarch-parse.y;h=8704687706df50aa15aff05f97e4560d7ec6fa23;hb=refs/heads/master#l131 > > Zhensong: does "old asm code" here mean we should remove %plt from "new" > assembly code, i. e. stop to print %plt(...) in GCC completely? > I think '%plt' also needs to be removed from the readability of the assembly code.:-\ --------------B8B6D4E3CB585CFE0BAF535C--