From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SE+A=DO=mentor.com=joseph_myers@sourceware.org>
Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180])
	by sourceware.org (Postfix) with ESMTPS id 372EF3858C20
	for <gcc-patches@gcc.gnu.org>; Fri, 28 Jul 2023 20:32:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 372EF3858C20
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="6.01,238,1684828800"; 
   d="scan'208";a="13003533"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa3.mentor.iphmx.com with ESMTP; 28 Jul 2023 12:32:39 -0800
IronPort-SDR: viaVCy0V3pM6Q6ahvgHEXtdoKz7VhcfEnAs8byyKiAFv3c4y+hiIZ47S3eRjVzZJNXSRdWCrYc
 sE0IhG/sp9QNYC7zyJExJ54YFBPnUrk+x8tTofAwGT9+5PNJ480SpRaVSyKaA1NmWag8rTOBKu
 iNfuio57rPxeaguTHO0IGOVLZIH5ZNlgbBlu6U40POdcRoEkuDiHDKiJgJz3Mp5NTr3KpOmcmt
 QnFi1P8c9sSfjNEBfb04y+kwftFzt9DSK7idg/IgpYl9Gi+oQynNCi2OEEujOKlyQg7TUJ0mlW
 Sv4=
Date: Fri, 28 Jul 2023 20:32:31 +0000
From: Joseph Myers <joseph@codesourcery.com>
To: Hamza Mahfooz <someguy@effective-light.com>
CC: <gcc-patches@gcc.gnu.org>, Richard Biener <rguenther@suse.de>, Marek
 Polacek <polacek@redhat.com>, Martin Uecker <uecker@tugraz.at>
Subject: Re: [PATCH RESEND] c: add -Wmissing-variable-declarations
 [PR65213]
In-Reply-To: <20230718191431.50059-1-someguy@effective-light.com>
Message-ID: <a5ebb249-e267-ecf9-96c0-7926da85a5ac@codesourcery.com>
References: <20230718191431.50059-1-someguy@effective-light.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To
 svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10)
X-Spam-Status: No, score=-3105.2 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, 18 Jul 2023, Hamza Mahfooz wrote:

> Resolves:
> PR c/65213 - Extend -Wmissing-declarations to variables [i.e. add
> -Wmissing-variable-declarations]
> 
> gcc/c-family/ChangeLog:
> 
> 	PR c/65213
> 	* c.opt (-Wmissing-variable-declarations): New option.
> 
> gcc/c/ChangeLog:
> 
> 	PR c/65213
> 	* c-decl.cc (start_decl): Handle
> 	-Wmissing-variable-declarations.
> 
> gcc/ChangeLog:
> 
> 	PR c/65213
> 	* doc/invoke.texi (-Wmissing-variable-declarations): Document
> 	new option.
> 
> gcc/testsuite/ChangeLog:
> 
> 	PR c/65213
> 	* gcc.dg/Wmissing-variable-declarations.c: New test.

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com