From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6589B38582A1 for ; Sat, 2 Dec 2023 08:45:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6589B38582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6589B38582A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701506731; cv=none; b=I+mT7WmO3ESqZ9RtLhd2oreuzMOTtWlu2vKXMxVjpTbrU4ngTBC2Yezlg/nAl/L5ZiBon2mFCXTaKYCGIChyiuIM0BpdXEXmgiOhXpdgyDzU1qM4yKyGIZqoKcSiMEQAa/rPcxP296i9rqEypbAblrg52zTbu2mb7DUr5LtWCcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701506731; c=relaxed/simple; bh=HKAxxVPshYkp9OjZOuyVy6l7zqzyQ+sxFt1h8/ecnAc=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=IW4KWQ8oAdmRRdIIIpVhYs0sRuZMqUzLPLIbNtPd2noF4n8SDCpKG+9Wf1LbLN18vhhcKbM6OoYZG2xjZFW4mFCR3eLij2dUZISiu8jdK504MvotY5uujSRxHBffyorKJaGamp0XAS+/5zfWpjDu6mE430nGQbvHfIDiTCiaLfc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9Lcu-0001oS-6b for gcc-patches@gcc.gnu.org; Sat, 02 Dec 2023 03:45:29 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8CxtPCl7mpliV0+AA--.59793S3; Sat, 02 Dec 2023 16:45:25 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxrdyk7mplEVtSAA--.50771S3; Sat, 02 Dec 2023 16:45:25 +0800 (CST) Subject: Re:[pushed] [PATCH v1] LoongArch: Remove duplicate definition of CLZ_DEFINED_VALUE_AT_ZERO. To: Xi Ruoyao , Li Wei , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231128075635.2484351-1-liwei@loongson.cn> From: chenglulu Message-ID: Date: Sat, 2 Dec 2023 16:45:24 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Bxrdyk7mplEVtSAA--.50771S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7CryrtFWxtFyfXF4UKF4UGFX_yoW8ZFWrpa 9xAFWUtr48GFsIgwsYq348Wr4UKFyUGrnrZFnIqrW8JF47uwn5KF4kKr4DXF9rXw48ArWf X3Z5WFyjvayFywcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4j6r4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAF wI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4 CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG 67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMI IYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E 14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU7pnQ UUUUU Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-1.534,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed to r14-6070. 在 2023/11/29 上午9:53, Xi Ruoyao 写道: > On Tue, 2023-11-28 at 15:56 +0800, Li Wei wrote: >> In the r14-5547 commit, C[LT]Z_DEFINED_VALUE_AT_ZERO were defined at >> the same time, but in fact, CLZ_DEFINED_VALUE_AT_ZERO has already been >> defined, so remove the duplicate definition. >> >> gcc/ChangeLog: >> >> * config/loongarch/loongarch.h (CTZ_DEFINED_VALUE_AT_ZERO): Add >>   description. >> (CLZ_DEFINED_VALUE_AT_ZERO): Remove duplicate definition. > LGTM. > > Interestingly the compiler does not give any warning when a macro is > redefined but with exactly same definition. > >> --- >>  gcc/config/loongarch/loongarch.h | 9 +++------ >>  1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h >> index 115222e70fd..fa8a3f5582f 100644 >> --- a/gcc/config/loongarch/loongarch.h >> +++ b/gcc/config/loongarch/loongarch.h >> @@ -288,10 +288,12 @@ along with GCC; see the file COPYING3.  If not see >>  /* Define if loading short immediate values into registers sign extends.  */ >>  #define SHORT_IMMEDIATES_SIGN_EXTEND 1 >> >> -/* The clz.{w/d} instructions have the natural values at 0.  */ >> +/* The clz.{w/d}, ctz.{w/d} instructions have the natural values at 0.  */ >> >>  #define CLZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ >>    ((VALUE) = GET_MODE_UNIT_BITSIZE (MODE), 2) >> +#define CTZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ >> +  ((VALUE) = GET_MODE_UNIT_BITSIZE (MODE), 2) >> >>  /* Standard register usage.  */ >> >> @@ -1239,8 +1241,3 @@ struct GTY (()) machine_function >> >>  #define TARGET_EXPLICIT_RELOCS \ >>    (la_opt_explicit_relocs == EXPLICIT_RELOCS_ALWAYS) >> - >> -#define CLZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ >> -  ((VALUE) = GET_MODE_UNIT_BITSIZE (MODE), 2) >> -#define CTZ_DEFINED_VALUE_AT_ZERO(MODE, VALUE) \ >> -  ((VALUE) = GET_MODE_UNIT_BITSIZE (MODE), 2)