From: Jeff Law <law@redhat.com>
To: JiangNing OS <jiangning@os.amperecomputing.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization
Date: Wed, 24 Jul 2019 16:00:00 -0000 [thread overview]
Message-ID: <a6d5306e-2692-ba3b-19d9-c912c4b9e642@redhat.com> (raw)
In-Reply-To: <MN2PR01MB5424AEF5B753FFAEB6FEB00E9CC70@MN2PR01MB5424.prod.exchangelabs.com>
On 7/22/19 10:26 PM, JiangNing OS wrote:
> This patch is to fix PR91195. Is it OK for trunk?
>
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index 711a31ea597..4db36644160 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,9 @@
> +2019-07-22 Jiangning Liu <jiangning.liu@amperecomputing.com>
> +
> + PR middle-end/91195
> + * tree-ssa-phiopt.c (cond_store_replacement): Work around
> + -Wmaybe-uninitialized warning.
I'll conditionally OK this for the trunk. Give Richi 48hrs to chime in
if he doesn't like the TREE_NO_WARNING approach.
For anyone watching the thread, the setting of TREE_NO_WARNING here is
only done in those cases where we haven't already seen a dominating
memory reference, so it minimizes how often we set TREE_NO_WARNING.
jeff
next prev parent reply other threads:[~2019-07-24 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 5:52 JiangNing OS
2019-07-23 16:31 ` Martin Sebor
2019-07-24 15:28 ` Jeff Law
2019-07-24 17:00 ` Martin Sebor
2019-07-24 17:23 ` Jeff Law
2019-07-24 18:09 ` Martin Sebor
2019-07-25 6:27 ` JiangNing OS
2019-07-25 19:09 ` Martin Sebor
2019-07-26 5:07 ` Jeff Law
2019-07-29 16:10 ` Jakub Jelinek
2019-07-30 8:35 ` Richard Biener
2019-07-30 8:36 ` Jakub Jelinek
2019-07-30 8:49 ` Richard Biener
2019-07-30 14:51 ` Martin Sebor
2019-08-07 22:17 ` Jeff Law
2019-09-03 20:22 ` Jeff Law
2019-07-24 16:00 ` Jeff Law [this message]
2019-07-29 16:03 ` Jakub Jelinek
2019-09-03 20:27 ` Jeff Law
2019-11-20 0:14 ` Jakub Jelinek
2019-11-20 2:33 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d5306e-2692-ba3b-19d9-c912c4b9e642@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jiangning@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).