From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2D77D3858429 for ; Thu, 11 Aug 2022 19:30:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D77D3858429 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-512-jg0uK7UaNmqyUf5BoEtqJw-1; Thu, 11 Aug 2022 15:30:49 -0400 X-MC-Unique: jg0uK7UaNmqyUf5BoEtqJw-1 Received: by mail-qv1-f72.google.com with SMTP id ln10-20020a0562145a8a00b004749ae27efcso10033142qvb.22 for ; Thu, 11 Aug 2022 12:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc; bh=SFlRP/UuUb8LwP9TUcFpH6FNnhXGy7hi1bjkBNRxToo=; b=O4LVcTuG8RdCR6x0OU+dDHJsKou7NGLWeG6gKK1E862ff5o+w2lHbLRgQqX4ZsZ8Gd RCfW0Vy09qclLKGH7bm+g5+J4rsrlVT/kAiSWbDpxGgD5MiFoaN/lGtk6n4xvHjl50uT LUheL6vYVaNIsXpWzwiSJj64gP64F+0JMZGRs4AGfD/vY3EXmfyBGO+EsCj2wPDWWngg Vj8duwQb8pOdNjrSp9WQIgK93Jq3zuDEJtEJ2V6GEc9lYbqr+J5ZzRzbAAMtNtFmvQUY gdtv5u0N1TzZK5iVQ/ds2pEdV9A21/tPafwc5gTwrGwrwdTyf45sR1psNfI3IPookWJy G+kA== X-Gm-Message-State: ACgBeo1F60ztP4eDngpa7soEDOWs9W0ex5k3CwmquhVYMAfsb+lk5/BI usy3kyoZXzsuyJMaKVO5rAuXyoo+QHVX1dp9p205VHxX7X4hMUbNUjS/ZLNXsNhac3sYn6S+iV+ vxNhFCqz/aGfZiIHhkA== X-Received: by 2002:a05:620a:2710:b0:6b5:bf24:10e9 with SMTP id b16-20020a05620a271000b006b5bf2410e9mr437689qkp.28.1660246248611; Thu, 11 Aug 2022 12:30:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR7lfGOxwEw6KSBlqdcEAnQOwvjKHYKJr9+69G2ILfvAOEm2ObvDJ/6znbjlnQcEcOUwSNNv+g== X-Received: by 2002:a05:620a:2710:b0:6b5:bf24:10e9 with SMTP id b16-20020a05620a271000b006b5bf2410e9mr437673qkp.28.1660246248352; Thu, 11 Aug 2022 12:30:48 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id b16-20020ac87550000000b0031ee3449f34sm161635qtr.86.2022.08.11.12.30.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 12:30:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/2 v2] analyzer: out-of-bounds checker [PR106000] From: David Malcolm To: Tim Lange , gcc-patches@gcc.gnu.org Date: Thu, 11 Aug 2022 15:30:46 -0400 In-Reply-To: <20220811172452.65996-2-mail@tim-lange.me> References: <20220809211943.82098-1-mail@tim-lange.me> <20220811172452.65996-1-mail@tim-lange.me> <20220811172452.65996-2-mail@tim-lange.me> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2022 19:30:54 -0000 On Thu, 2022-08-11 at 19:24 +0200, Tim Lange wrote: > This patch adds an experimental out-of-bounds checker to the > analyzer. > > The checker was tested on coreutils, curl, httpd and openssh. It is > mostly > accurate but does produce false-positives on yacc-generated files and > sometimes when the analyzer misses an invariant. These cases will be > documented in bugzilla. > Regression-tested on Linux x86-64, further ran the analyzer tests > with > the -m32 option. [...snip...] Thanks for the updated patch. This version is OK for trunk [1]. Dave [1] as I mentioned before, I plan to reword the diagnostic once it's in trunk, but I'll do that myself, rather than be a backseat driver.