From: dbroemmel <dibr-bugzilla@daswigwam.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression] THREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA
Date: Fri, 01 Sep 2017 12:27:00 -0000 [thread overview]
Message-ID: <a7154299-b247-86ef-8c99-c4c508e9f7c3@daswigwam.de> (raw)
In-Reply-To: <20170901120842.GJ2323@tucnak>
> This is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/.
Well, that's a path where I found some Fortran OpenMP stuff, I didn't
look for other places.
> That said, I fail to see why such a large testcase is needed, wouldn't a
> simple
> ! PR fortran/81841
> ! { dg-do compile }
>
> block data
> implicit none
> integer :: int2
> real :: flt2
> common /c_block_2/ int2, flt2
> !$OMP THREADPRIVATE(/c_block_2/)
> data int2, flt2 /2, 2.2/
> end block data
>
> testcase in gfortran.dg/gomp/ be sufficient here?
That would suffice and is the first testcase I added to PR81841. It was
suggested I could add runtime tests as well, so I tried.
Dirk
next prev parent reply other threads:[~2017-09-01 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 9:09 dbroemmel
2017-09-01 12:08 ` Jakub Jelinek
2017-09-01 12:27 ` dbroemmel [this message]
2017-09-01 13:11 ` Jakub Jelinek
2017-09-01 13:47 ` dbroemmel
2017-09-01 13:55 ` Jakub Jelinek
2017-11-23 20:26 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7154299-b247-86ef-8c99-c4c508e9f7c3@daswigwam.de \
--to=dibr-bugzilla@daswigwam.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).