From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27214 invoked by alias); 1 Aug 2017 15:11:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 27060 invoked by uid 89); 1 Aug 2017 15:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout3.netcologne.de Received: from cc-smtpout3.netcologne.de (HELO cc-smtpout3.netcologne.de) (89.1.8.213) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Aug 2017 15:11:25 +0000 Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202]) by cc-smtpout3.netcologne.de (Postfix) with ESMTP id 1324112805; Tue, 1 Aug 2017 17:11:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin2.netcologne.de (Postfix) with ESMTP id 0DFFC11DEB; Tue, 1 Aug 2017 17:11:23 +0200 (CEST) Received: from [78.35.135.193] (helo=cc-smtpin2.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 59809a1b-02b8-7f0000012729-7f000001e128-1 for ; Tue, 01 Aug 2017 17:11:23 +0200 Received: from [192.168.178.20] (xdsl-78-35-135-193.netcologne.de [78.35.135.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA; Tue, 1 Aug 2017 17:11:20 +0200 (CEST) Subject: Re: [PATCH, Fortran] Correctly set -fd-lines-as-comments with -fdec To: Fritz Reese , fortran , gcc-patches References: From: Thomas Koenig Message-ID: Date: Tue, 01 Aug 2017 15:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00098.txt.bz2 Hi Fritz, > This is a simple patch. The original intent was for -fdec to set > -fd-lines-as-comments by default if flag_d_lines was unspecified by > the user. However, currently flag_d_lines is interrogated in > set_dec_flags(), usually before its final value is determined. The > attached patch fixes this behavior to work as intended. > > Any objections for trunk? If not I think it is safe to commit. Did you regression-test? OK for trunk if yes. Regards Thomas