From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Christophe Lyon <christophe.lyon@linaro.org>,
gcc-patches@gcc.gnu.org, richard.sandiford@arm.com,
richard.earnshaw@arm.com, kyrylo.tkachov@arm.com
Subject: Re: [PATCH] testsuite/arm: Fix bfloat16_vector_typecheck_[12].c tests
Date: Thu, 30 Nov 2023 11:45:11 +0000 [thread overview]
Message-ID: <a736c410-b749-4a9d-8f31-886d38c832ac@foss.arm.com> (raw)
In-Reply-To: <20231130101545.3206213-1-christophe.lyon@linaro.org>
On 30/11/2023 10:15, Christophe Lyon wrote:
> After commit r14-5617-gb8592186611, int32x[24]_t types now use
> elements of 'long int' type instead of 'int' on arm-eabi (it's still
> 'int' on arm-linux-gnueabihf). Both are 32-bit types anyway.
>
> This patch adjust the two tests so that they optionnally accept 'long '
> before 'int' in the expected error message.
>
> 2023-11-30 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/testsuite/
> * gcc.target/arm/bfloat16_vector_typecheck_1.c: Update expected
> error message.
> * gcc.target/arm/bfloat16_vector_typecheck_2.c: Likewise.
OK.
R.
> ---
> gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c | 4 ++--
> gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_2.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c b/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c
> index f3c350b4cfc..470c13125fb 100644
> --- a/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c
> +++ b/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_1.c
> @@ -119,9 +119,9 @@ bfloat16x4_t footest (bfloat16x4_t vector0)
> (bfloat16x4_t) { is_a_short_vec }; /* { dg-error {incompatible types when initializing type '__bf16' using type 'int16x4_t'} } */
>
> (bfloat16x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '__bf16' using type 'bfloat16x4_t'} } */
> - (int32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'int' using type 'bfloat16x4_t'} } */
> + (int32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '(?:long )?int' using type 'bfloat16x4_t'} } */
> (float32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'float' using type 'bfloat16x4_t'} } */
> - (int32x2_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'int' using type 'bfloat16x4_t'} } */
> + (int32x2_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '(?:long )?int' using type 'bfloat16x4_t'} } */
> (float16x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '__fp16' using type 'bfloat16x4_t'} } */
> (int16x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'short int' using type 'bfloat16x4_t'} } */
>
> diff --git a/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_2.c b/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_2.c
> index de0ade52c10..4e0d37907ce 100644
> --- a/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_2.c
> +++ b/gcc/testsuite/gcc.target/arm/bfloat16_vector_typecheck_2.c
> @@ -111,7 +111,7 @@ bfloat16x8_t footest (bfloat16x8_t vector0)
> (bfloat16x8_t) { is_a_short_vec }; /* { dg-error {incompatible types when initializing type '__bf16' using type 'int16x8_t'} } */
>
> (bfloat16x8_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '__bf16' using type 'bfloat16x8_t'} } */
> - (int32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'int' using type 'bfloat16x8_t'} } */
> + (int32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '(?:long )?int' using type 'bfloat16x8_t'} } */
> (float32x4_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'float' using type 'bfloat16x8_t'} } */
> (int64x2_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type 'long long int' using type 'bfloat16x8_t'} } */
> (float16x8_t) { glob_bfloat_vec }; /* { dg-error {incompatible types when initializing type '__fp16' using type 'bfloat16x8_t'} } */
prev parent reply other threads:[~2023-11-30 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 10:15 Christophe Lyon
2023-11-30 11:45 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a736c410-b749-4a9d-8f31-886d38c832ac@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=richard.earnshaw@arm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).