From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 64B76384F037 for ; Mon, 14 Nov 2022 19:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64B76384F037 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-13bd19c3b68so13549689fac.7 for ; Mon, 14 Nov 2022 11:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=WRQKUShZA+Fv9CH9cbSP6IQl2PkPGnKKcJGTXlQuSW0=; b=ON3+JVAI1GDcFjAb+tFjmZIBsHl/mgSPlfgKYyKUZF0vefzeMn2K+tEHoyiYCOXVyY F2PHxU1WE4NUMfJwYP3eaKLxAgXZLzIjrIEE979/7mLqH+8cyfxaycylna2nxEDUDJ4W jfQXYpLuHsMoNRCeV4DTxMgd1+ffU40AGzwZVja7c2tr+InVkN/Nd7Vt7KYhpkmjQWqy 5QEGboIKOLih5SgCG0fE96pygapfDjUZ2vwF/VG2shJjBdZW2SmRuYIIRvokG4kyO4xf 2LqN8VPa7bAPv3/IHkOmZ3AbePHL3XKuUXXVJj9q2Waubr5M1rniUanL32b2YeO17Qko UkZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WRQKUShZA+Fv9CH9cbSP6IQl2PkPGnKKcJGTXlQuSW0=; b=N122qGceckGki2XncKsTwO1u0xghLsmS51m+yWI05Er4Rs88I41IXqrK1D86mKy0WL KxVi34VnaeIR5mh7d3BWhZahdpp6XUFC7yVwB9afqc3+yIS8pFWKx/5l+Q+d6NKO4Eoa kITyQ5cPhFgOnJfAUlVdvmzZlrGj76gTAozg3dBnzQOd8ruymYWDP7E4DBGOLEBW4cKb OjJar7M8n4N5CWfv8t7dLhgy/6PzL/OiU2V3lYTHm/z563sI2LclWoQamNH5jD9gwD4Z yzhcYOxyvfTNYjpE971slxPXsV3aT8pbmf/f/PcUcgoQ1ItjX7ot5f2qtubEU/oiwCqN KC0A== X-Gm-Message-State: ANoB5pm70OxSiim5nj+tX8mEOuGIOrFNF2k3CmEQ9WfdxGceTopW/sjC 81lfDhzNni7i7tPw0RjWVZE= X-Google-Smtp-Source: AA0mqf4iDPP8BOHpCyJPf2lZbRIJbAAOA1i/CuhFKC5PlvWln/8opBwTgDu81osF8toaUd17wqH9+Q== X-Received: by 2002:a05:6870:cb9b:b0:12d:4244:43d0 with SMTP id ov27-20020a056870cb9b00b0012d424443d0mr7594744oab.207.1668452670563; Mon, 14 Nov 2022 11:04:30 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u14-20020a4a85ce000000b0049f098f4fb4sm3911568ooh.24.2022.11.14.11.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 11:04:29 -0800 (PST) Content-Type: multipart/alternative; boundary="------------mF0vemyYMNfsjwYv3O5030cr" Message-ID: Date: Mon, 14 Nov 2022 12:04:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 3/7] riscv: Enable overlap-by-pieces via tune param Content-Language: en-US To: =?UTF-8?Q?Christoph_M=c3=bcllner?= , Philipp Tomsich Cc: Vineet Gupta , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman References: <20221113230521.712693-1-christoph.muellner@vrull.eu> <20221113230521.712693-4-christoph.muellner@vrull.eu> <72925543-48c1-12df-f65f-618c38179835@rivosinc.com> From: Jeff Law In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------mF0vemyYMNfsjwYv3O5030cr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/14/22 01:29, Christoph Müllner wrote: > > > On Mon, Nov 14, 2022 at 8:59 AM Philipp Tomsich > wrote: > > On Mon, 14 Nov 2022 at 03:48, Vineet Gupta > wrote: > > > > > > > > On 11/13/22 15:05, Christoph Muellner wrote: > > > > > > +static bool > > > +riscv_overlap_op_by_pieces (void) > > > +{ > > > +  return tune_param->overlap_op_by_pieces; > > > > Does this not need to be gated on unaligned access enabled as well. > > I assume you mean "&& !STRICT_ALIGNMENT"? > > > I think the case that slow_unaligned_access and overlap_op_by_pieces will > both be set will not occur (we can defer the discussion about that > until then). > Gating overlap_op_by_pieces with !TARGET_STRICT_ALIGN is a good idea. > It will be fixed for a v2. OK with that change. I'm still working through 7/7.  I may not have enough left in my tank to get through that one today. jeff --------------mF0vemyYMNfsjwYv3O5030cr--