From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 252BF3858C50 for ; Tue, 12 Sep 2023 17:25:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 252BF3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-CSE-ConnectionGUID: 1CaTglW5SeG0N+3wwcB6rg== X-CSE-MsgGUID: H+RLIUIdQf+y+NivfUHHEQ== X-IronPort-AV: E=Sophos;i="6.02,139,1688457600"; d="scan'208";a="18898612" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 12 Sep 2023 09:25:32 -0800 IronPort-SDR: nFkvObDzAWi3cpwX0yEAtmCMDXExF5wItCErT6MYniCBqx5Sbe2NfWn0gfYIrer2jCGO056bYt UCuH+nvBhbW4W/wJOAUjNrtkmTywXsxKui2sXVwkixMsQoBtT7CAWjMVQSP+zLjct65MlU7frL IKt+OGE5j6Xs6ZyV1Wpfvv0YbeI3q4W6+evKv2b5BRsLNt14CgRfg+vOX6r+3mSFT5hYKeQPEA Who5QQLSqgqg7AwxXkSym3fQaglkNSRX/IfgXOfV5PrAD6So3w8Gk2ppzHNOboRvhSoHgePUlA 2cc= Date: Tue, 12 Sep 2023 17:25:28 +0000 From: Joseph Myers To: Sylvain Noiry CC: Subject: Re: [PATCH v2 08/11] Native complex ops: Add explicit vector of complex In-Reply-To: <20230912100713.1074-9-snoiry@kalrayinc.com> Message-ID: References: <20230717090250.4645-10-snoiry@kalrayinc.com> <20230912100713.1074-1-snoiry@kalrayinc.com> <20230912100713.1074-9-snoiry@kalrayinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3104.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 12 Sep 2023, Sylvain Noiry via Gcc-patches wrote: > Summary: > Allow the creation and usage of builtins vectors of complex > in C, using __attribute__ ((vector_size ())) If you're adding a new language feature like this, you need to update extend.texi to explain the valid uses of the attribute for complex types, and (under "Vector Extensions") the valid uses of the resulting vectors. You also need to add testcases to the testsuite for such vectors - both execution tests covering valid uses of the vectors, and tests that invalid declarations or uses of such vectors (uses with any operator, or other operand to such operator, that aren't valid) are properly rejected - go through all cases of operators, with one or two complex vector operands, of the same or different types, and with different choices for what type the other operand might be when one has complex vector type, and make sure they are all properly tested and do have the desired and documented semantics. If the intended semantics are the same for C and C++, the tests should be c-c++-common tests. Any cases where the intended semantics are different will need separate tests for each language or appropriately conditional test assertions in c-c++-common. -- Joseph S. Myers joseph@codesourcery.com