From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 381993857807 for ; Tue, 25 Aug 2020 19:16:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 381993857807 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-LPPVGPn7P3uSnzN9P0ObWw-1; Tue, 25 Aug 2020 15:16:15 -0400 X-MC-Unique: LPPVGPn7P3uSnzN9P0ObWw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3CDA189E605; Tue, 25 Aug 2020 19:16:14 +0000 (UTC) Received: from ovpn-113-190.phx2.redhat.com (ovpn-113-190.phx2.redhat.com [10.3.113.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A77910013C2; Tue, 25 Aug 2020 19:16:14 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] MSP430: Simplify and extend shift instruction patterns From: Jeff Law Reply-To: law@redhat.com To: Jozef Lawrynowicz , gcc-patches@gcc.gnu.org Date: Tue, 25 Aug 2020 13:16:13 -0600 In-Reply-To: <20200721182953.wh2sprenianogipq@jozef-acer-manjaro> References: <20200721181715.frr5xycz7wvxxkym@jozef-acer-manjaro> <20200721182953.wh2sprenianogipq@jozef-acer-manjaro> Organization: Red Hat User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 19:16:20 -0000 On Tue, 2020-07-21 at 19:29 +0100, Jozef Lawrynowicz wrote: > The implementation of define_expand and define_insn patterns to handle > shifts in the MSP430 backend is inconsistent, resulting in missed > opportunities to make best use of the architecture's features. > > There's now a single define_expand used as the entry point for all valid > shifts, and the decision to either use a helper function to perform the > shift (often required for the 430 ISA), or fall through to the > define_insn patterns can be made from that expander function. > > Shifts by a constant amount have been grouped into one define_insn for > each type of shift, instead of having different define_insn patterns for > shifts by different amounts. > > A new target option "-mmax-inline-shift=" has been added to allow tuning > of the number of shift instructions to emit inline, instead of using > a library helper function. > > Successfully regtested on trunk for msp430-elf, ok to apply? OK jeff