Re: [patch, fortran] PR109662 Namelist input with comma after name accepted

[Jerry D <jvdelisle2@gmail.com>]

On 5/6/23 11:15 AM, Harald Anlauf via Fortran wrote:
> Hi Jerry, Steve,
> 
> I think I have to pour a little water into the wine.
> 
> The patch fixes the reported issue only for a comma after
> the namelist name, but we still accept a few other illegal
> characters, e.g. ';', because:
> 
> #define is_separator(c) (c == '/' ||  c == ',' || c == '\n' || c == ' ' \
>                           || c == '\t' || c == '\r' || c == ';' || \
>               (dtp->u.p.namelist_mode && c == '!'))
> 
> We don't want that in standard conformance mode, or do we?
> 
> Cheers,
> Harald
> 
> On 5/6/23 06:02, Steve Kargl via Gcc-patches wrote:
>> On Fri, May 05, 2023 at 08:41:48PM -0700, Jerry D via Fortran wrote:
>>> The attached patch adds a check for the invalid comma and emits a 
>>> runtime
>>> error if -std=f95,f2003,f2018 are specified at compile time.
>>>
>>> Attached patch includes a new test case.
>>>
>>> Regression tested on x86_64-linux-gnu.
>>>
>>> OK for mainline?
>>>
>>
>> Yes.  Thanks for the fix.  It's been a long time since
>> I looked at libgfortran code and couldn't quite determine
>> where to start to fix this.
>>
> 

As I think back, I don't recall ever seeing a semi-colon used after a 
NAMELIST name, so I think we should reject it always.  The other "soft" 
blanks we should allow.

I will make a another patch on trunk to reject the semi-colon and if no 
one objects here I will test and push it.

Regards,

Jerry