From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 593B63858D35; Sun, 25 Jun 2023 13:09:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 593B63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1b5251e5774so9482655ad.1; Sun, 25 Jun 2023 06:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687698589; x=1690290589; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nKM6YbyVC9/m2LlV9Jy/haITXhaVxrMwgeCYl+m4X1A=; b=R8eWWPM/f/pzTI0igZNp1h+7SomMFGn04MnjwQ3LdvVMLEBKvcbFro3fmMWzpiuTXC ftuQVV2whtTOBrspqXJRDfWywzpaX8lsmsVlC9miwxiPVWiwqC9RPDGJscR1sxskhdqK JiWJ79lPGEnFbJ0KZBNBuEqbP23VZkw2ZpZDsY4BTsfau8yx2Z2f/4cILRbwnmBAd7Tn k7UaEaK8YruPvrD5wkjbkwJr9Ft2XRaBOjWwaK0Qo/EEaLBHdWqmdb5Xy+KwtjkZpumk 9RcR1Nqb5VYkEeEZYUWDfIqoCkbHMNNcr5Sw3Nd/O9PzmWJZHe/Tqcd/mCW422/aCc0t kg8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687698589; x=1690290589; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nKM6YbyVC9/m2LlV9Jy/haITXhaVxrMwgeCYl+m4X1A=; b=EePtuPOUPAiIyTyvpmrwt/t0f+y1xS4Plbko8R8FtmQW0VfYHWRwJ3mgbkh3nm1YDi aIYQWliN73qQbJwcg+WV85uOISCUVmp/J4ODwwPNSFzshAvKxKjK3Ohazas1OSquGFBK PfkQyWyYlDd23hjvySkwCnnHE+XDlrXZnOtjwU/9pCW6HkQI3v/kV/Ujn7DXI4IMzl28 LlGuk/cxEpD4J/LgBqpGE5O35cU0IQChszIchMGWRkuyChmwetZ9XDjElhV4f4w3ppaY gJ4Vhv1dfwDS61rMWUtZLjg3kKFq7690owMMpFdb+/cFoQiTfh4aV0eA9A+eYhKlDm9T R2pQ== X-Gm-Message-State: AC+VfDwj446mEDfpAx1eQjr8mUAqQa7knsDtSDu1CuYXYhg3o8fHdOFf ZgMGOmfPoUd4oxgtyjO6nso= X-Google-Smtp-Source: ACHHUZ6Mp/ZXlsYd8EoyMR8EitcYlrWNonD0k/Ly5Ry8sH3IMe2kXx1eF2TQUQM1psABX+a3p2ourA== X-Received: by 2002:a17:903:2787:b0:1b3:696f:b83 with SMTP id jw7-20020a170903278700b001b3696f0b83mr1359067plb.45.1687698589255; Sun, 25 Jun 2023 06:09:49 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id f3-20020a170902860300b0019f3cc463absm2491294plo.0.2023.06.25.06.09.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jun 2023 06:09:48 -0700 (PDT) Message-ID: Date: Sun, 25 Jun 2023 07:09:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] cprop_hardreg: fix ORIGINAL_REGNO/REG_ATTRS/REG_POINTER handling Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Thiago Jung Bauermann , Tamar Christina , Jakub Jelinek , Richard Biener , Sergei Trofimovich , Andrew Pinski , Tobian Burnus , Jeff Law , Kito Cheng , Manolis Tsamis References: <20230622111154.2837175-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20230622111154.2837175-1-philipp.tomsich@vrull.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/22/23 05:11, Philipp Tomsich wrote: > From: Manolis Tsamis > > Fixes: 6a2e8dcbbd4bab3 > > Propagation for the stack pointer in regcprop was enabled in > 6a2e8dcbbd4bab3, but set ORIGINAL_REGNO/REG_ATTRS/REG_POINTER for > stack_pointer_rtx which caused regression (e.g., PR 110313, PR 110308). > > This fix adds special handling for stack_pointer_rtx in the places > where maybe_mode_change is called. This also adds an check in > maybe_mode_change to return the stack pointer only when the requested > mode matches the mode of stack_pointer_rtx. > > PR 110308 Should be PR debug/110308 > > gcc/ChangeLog: > > * regcprop.cc (maybe_mode_change): Check stack_pointer_rtx mode. > (find_oldest_value_reg): Special handling of stack_pointer_rtx. > (copyprop_hardreg_forward_1): Ditto. > > gcc/testsuite/ChangeLog: > > * g++.dg/torture/pr110308.C: New test. I don't doubt the need for the special handling of the stack pointer, but it's not obvious why it's needed. So my request is that both humks which specialize handling of ORIGINAL_REGNO, REG_ATTRS & REG_POINTER have a comment indicating why we must not adjust those values when NEW_RTX is STACK_POINTER_RTX. OK with that change. Jeff