On 03.05.21 19:38, Jakub Jelinek wrote:
> All the above ChangeLog lines are too long.
Fixed.
> The above line is too long too, ...

I counted 80 characters  - but the line break is now required for: used
'(...)' around '... == ...').

>> +                      if (is_fp_and_or)
>> +                        new_var2 = fold_build2_loc (
>> +                                     clause_loc, NE_EXPR,
>> +                                     integer_type_node, new_var,
>> +                                     build_zero_cst (TREE_TYPE (new_var)));
> Formatting, would be nice to avoid the ( at the end of line, e.g.
>                           {
>                             tree zero = build_zero_cst (TREE_TYPE (new_var));
I added now the zero plus
> Please wrap the == into ()s.
Done.
> Though ref should have the same type new_var (or at least a compatible type),
> so I don't see the point of the && ... in there and of using two separate
> if (is_fp_and_or) blocks.

I have now merged the two parts into a single block - with a single zero
as proposed.

> For the testcases, would be nice to have one with _Complex int, though
> perhaps separately from the ones you've included because while float
> or _Complex double are standard, _Complex int is a GNU extension.

Done (reduction-4.c).

Unless there are further comments, I intent to commit it after the lunch
break.

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf