From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id CBAC338485A6 for ; Wed, 11 May 2022 11:15:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBAC338485A6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CBF5D1F37E; Wed, 11 May 2022 11:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1652267726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f0WB5gDSY52IZg/S2kvENWwJGZ2ZhyyyvSAp/YvMcwc=; b=z7nWsHspVq4ioEQuBa7MDlZdSNQLq08NerMH1pAR7xKH5QIzYsgPlrkKMZcbvI9PFwFkTK vtuNiFH+nLC6WhLRqfFtKNgKNKJjBQpZnXJV7vDoOFJxNKhOaxZ8EF7OU/IPtfr2Qh3eLl zaI1FAytazdL2ubbssWBFehEQRjgx1M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1652267726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f0WB5gDSY52IZg/S2kvENWwJGZ2ZhyyyvSAp/YvMcwc=; b=NyU9LI4zgrHWOJdqqdsLyZKDIe2JNo5/C9LI7WsCfOUTGAB+sTZnS+Bftn+nTxDEZ6TzNn 7gU9IQy/dg6laJAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B4A6E139F9; Wed, 11 May 2022 11:15:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sqTzKs6ae2KeQQAAMHmgww (envelope-from ); Wed, 11 May 2022 11:15:26 +0000 Message-ID: Date: Wed, 11 May 2022 13:15:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] configure: add --disable-fix-includes Content-Language: en-US To: Rainer Orth Cc: Joseph Myers , gcc-patches@gcc.gnu.org References: <2e2c7061-3f3f-fde4-6e8c-d2118820a5b6@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 11:15:29 -0000 On 5/11/22 13:00, Rainer Orth wrote: > Hi Martin, > >> On 5/9/22 23:14, Joseph Myers wrote: >>> If you add a new configure option, it should be documented in >>> install.texi. >>> >> >> Both comments fixed in the v2. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> From 58d431568d6b6163dd9cdc920239f173689a769c Mon Sep 17 00:00:00 2001 >> From: Martin Liska >> Date: Fri, 4 Feb 2022 13:42:14 +0100 >> Subject: [PATCH] configure: add --disable-fix-includes > > As I've mentioned before, I believe, the command is called fixincludes > in current gcc docs, and the option should reflect that, not introduce a > name used nowhere else. No, I can't use it, because even with current master using --disable-fixincludes means the tool is not built at all. It results with: g++ -g -DIN_GCC -fPIC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ -static-libgcc -o build/genchecksum \ build/genchecksum.o ../build-x86_64-pc-linux-gnu/libiberty/pic/libiberty.a make: *** No rule to make target '../build-x86_64-pc-linux-gnu/fixincludes/fixinc.sh', needed by 'stmp-fixinc'. Stop. make: *** Waiting for unfinished jobs.... Martin > >> Right now, fixinclude takes about 11 seconds on my machine, where >> it reads 130MB of header files. >> >> The number of fixed headers is negligible without any significant >> change. > > Please speak for Linux, but not for other targets ;-) > > Rainer >