From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 13753388264D for ; Tue, 18 Jun 2024 02:56:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13753388264D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13753388264D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718679387; cv=none; b=p2HeFUDAAmdbcfe6/o1qSBBePu/m06RbldCYbs3MzRBahuj1KUrZ4HEApB0cjEknMz7+vPTd0Ca8rTC/C/KmSExuGiUxHhie4Pe//d+wPFNGomFurBinIdY9NA0DKe/DTZYz0ybEMRHvQnWiQlbzDIJOwVU2GNIsGbZApOuomS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718679387; c=relaxed/simple; bh=uIiFoX6hBfo9tt7ylPcCBG4Tz0LavQ+DTzQy9dGNjUo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XsKzT3jq4k5nPngwh6EnwNv/Q0unpLtBaHU0dYZsZNFsC3mG3JGE2JWwaFo79gyps1itJ7XzDgIkFrtYRvifun7bBlfGi2Y1kVvjSz102S3nlD2jL5TC0j5y7/7emp1kOmzDx4B1sIgj1BXEIFQUnKBbU/6cXswxk+iV4YLyTyg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45I2RJ7x032283; Tue, 18 Jun 2024 02:56:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=6 vhuLGQpM8PzrvPueo2Z4MaMmNl5iJErK050gkzXzo0=; b=gEO0MXvVVHGQhdaRT o8B5z2I2q0fXaxC4H1jp3oRVSlgkPDyLorgpe/DEPyoPY6klPUQEXm4ITmgRF0Z6 znJMXosgIBMCT+CJ3G7kPqMcm9liESKmZz8moTgYVDIokyqPAYGosy9bkKj8vP7e +o6qq5RDTVjgJNazo/n3JKoD/m2omJKfx/YoGW9d0J6pxSBzUnjBMZRJQ/j4ufzj 3DDyKBa5yTnkmVBrff7BPKqt68g6Py4P5rn4F0WVZnx2dGLQbg6BZoixdJ9yuGDn Ds9sa5S1p2t9cCswjrFNFRYfEiyorESNHM8xAWqlyFXHugX7JFi7kLlzQq0WGcZH 80QIA== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yu11t82wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 02:56:21 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45I15iFA006226; Tue, 18 Jun 2024 02:56:20 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ysn9ufe60-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 02:56:20 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45I2uF9a51905016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jun 2024 02:56:17 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E27820043; Tue, 18 Jun 2024 02:56:15 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB7DB2004E; Tue, 18 Jun 2024 02:56:13 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 18 Jun 2024 02:56:13 +0000 (GMT) Message-ID: Date: Tue, 18 Jun 2024 10:56:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] rs6000, altivec-2-runnable.c update the require-effective-target Content-Language: en-US To: Peter Bergner , Carl Love Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool References: <600de562-39bf-4358-a128-2766fd775f4f@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BVL7r_cHzohUDgFzZJQTITHD0hCYvX8n X-Proofpoint-ORIG-GUID: BVL7r_cHzohUDgFzZJQTITHD0hCYvX8n X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-17_14,2024-06-17_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406180021 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/6/18 00:08, Peter Bergner wrote: > On 6/14/24 1:37 PM, Carl Love wrote: >> Per the additional feedback after patch: >> >> commit c892525813c94b018464d5a4edc17f79186606b7 >> Author: Carl Love >> Date: Tue Jun 11 14:01:16 2024 -0400 >> >> rs6000, altivec-2-runnable.c should be a runnable test >> >> The test case has "dg-do compile" set not "dg-do run" for a runnable >> test. This patch changes the dg-do command argument to run. >> >> gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog: >> * gcc.target/powerpc/altivec-2-runnable.c: Change dg-do >> argument to run. > > Test case altivec-1-runnable.c seems to have the same issue, in that it > is currently a dg-do compile test case rather than the intended dg-do run. Good catch! > Can you have a look at changing that to dg-do run too? My guess it that > this one will want something similar to some other altivec test cases, ala: > > /* { dg-do run { target vmx_hw } } */ > /* { dg-do compile { target { ! vmx_hw } } } */ > /* { dg-require-effective-target powerpc_altivec_ok } */ > /* { dg-options "-O2 -maltivec -mabi=altivec" } */ I'd expect the "-runnable" test case focuses on testing for run. Normally, the one without "-runnable" would focus on testing for compiling (scan some desired insn), but this altivec-1.c and altivec-1-runnable.c seems to test for different things, maybe we should separate them into different names if they don't test for a same test point. > > That said, I don't like not having a -mdejagnu-cpu=... here. > I think for our server cpus, this is fine, but on an embedded system > with a old ISA default for -mcpu=... (so we be doing a dg-do compile), > just adding -maltivec to that default may not make much sense for that > default and probably should be an error. Maybe something like: Yes, for some embedded cpus, there will be some error messages, but since we have powerpc_altivec_ok effective target, the error would make that effective target checking fail so I'd expect it'll stop it being tested (unsupported). > > /* { dg-do run { target vmx_hw } } */ > /* { dg-do compile { target { ! vmx_hw } } } */ > /* { dg-require-effective-target powerpc_altivec_ok } */ > /* { dg-options "-O2 -mdejagnu=power7" } */ > > ...makes more sense? Ke Wen & Segher, thoughts on that? > Ke Wen, should powerpc_altivec_ok be powerpc_altivec here??? Yes, I just pushed r15-1390 for this change. BR, Kewen