From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id 560F73858D37; Sat, 19 Nov 2022 13:02:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 560F73858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x331.google.com with SMTP id p16so5485816wmc.3; Sat, 19 Nov 2022 05:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=foYEB+57OrE/GIGBaVg6UxiBOrbPw1fC/I8cCnzFqTc=; b=HFPBzYiRtqQ8FUR/GibmSSsfiP+aDAvVsF0wUzCebFB5b705T3nd14RqLJh0g4gKar 9frT6vwIJJps8kePBxnmKDaDawQ8a3Xpo/HsOEDr2FLbGjkSXjp9ptTCV29DXBgM5UXC Q07bfyNucVCzx0XutGVFlhJNg5ZtVFo48R5GNHV42BoAQ4ilO9CPKHZkzEowKbhCSxuq 9q17wKt59MKJ/JikJgn0/67QRNdMA54NarkTn90pNBPXZC/0ychCzL/jjhnKijDoV9Sr qxjfCMW+4prJWKrk/7F+O4jUOeHgFh5ht8CAVwi2J0UltQ7mZMkTpH0m8TwfZqoE55qM 8fOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=foYEB+57OrE/GIGBaVg6UxiBOrbPw1fC/I8cCnzFqTc=; b=Fdh2kmGs2M54D91GZ8pAsRVWcx2zdpfSgRvbXpf8A1K7kgjMvgzhy26VcB6nqKVMUc WHBvaXCV23PHVin7QwslyYL3OoZ0Y94BOL+Si695//XLhnFtd4iujh2vNEQnrRt5vmb9 CVxZ0okSfsc7nBe0Vp3NFQBzOvM1lGD5TC4mONz7cZigCxG3QzMZaqoutZE3nRBYIqs0 qVHHoGmdza6fSrM8bh4LlOEKK+PJfThTogMBqYdI7ltnGjMN+dAuOGfD5WmfCVn0t7ea s97mDxKzZLytUBLC+uldjKQS/tWli7IhBHdHmhgQmBGWNkhCH0jzBg3bJ/hC4jSRIeT1 CKJA== X-Gm-Message-State: ANoB5pmDkI1cwUSOAAuW1cXeVeBVRkXMGokRf3jCnDLjabN+V8jlP1Sd T84UFQ7BfKR7jdVaJR77GYsHFwbQ1RU= X-Google-Smtp-Source: AA0mqf5N8jzxFfB7biGK5KMMQo25l69MoE0AT/RCi2wAjUeWztZlzkijY0bn1aJzPkWxg6sFgNHQSg== X-Received: by 2002:a05:600c:6011:b0:3c6:cc1d:89a with SMTP id az17-20020a05600c601100b003c6cc1d089amr931371wmb.78.1668862965803; Sat, 19 Nov 2022 05:02:45 -0800 (PST) Received: from ?IPV6:2a01:e0a:1dc:b1c0:dbf6:3958:e878:1557? ([2a01:e0a:1dc:b1c0:dbf6:3958:e878:1557]) by smtp.googlemail.com with ESMTPSA id r13-20020a05600c458d00b003c7087f6c9asm12935798wmo.32.2022.11.19.05.02.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 05:02:45 -0800 (PST) Content-Type: multipart/mixed; boundary="------------hYk6WqGs2wVwpQwIXltb1M0v" Message-ID: Date: Sat, 19 Nov 2022 14:02:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: fr To: "libstdc++@gcc.gnu.org" Cc: gcc-patches From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: [PATCH] Fix in _GLIBCXX_INLINE_VERSION mode X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------hYk6WqGs2wVwpQwIXltb1M0v Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Without this qualification I have this in _GLIBCXX_INLINE_VERSION mode: /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: note: candidate: 'template bool std::__9::isxdigit(_CharT, const locale&)' /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: note:   template argument deduction/substitution failed: /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540: note:   candidate expects 2 arguments, 1 provided /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: error: no matching function for call to 'isxdigit(const std::__9::basic_string_view::value_type&)' /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: note: candidate: 'template bool std::__9::isxdigit(_CharT, const locale&)' /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649: note:   template argument deduction/substitution failed: /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: note:   candidate expects 2 arguments, 1 provided compiler exited with status 1 FAIL: 17_intro/headers/c++2020/all_attributes.cc (test for excess errors) Excess errors: /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540: error: no matching function for call to 'isxdigit(const std::__9::basic_string_view::value_type&)' /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630: error: no matching function for call to 'isxdigit(const std::__9::basic_string_view::value_type&)' It sounds like the most reasonable fix as this is how toupper is being called.     libstdc++: Add missing std qualification on isxdigit calls     libstdc++-v3/ChangeLog             * include/std/format: Add std qualification on isxdigit calls. Ok to commit ? François --------------hYk6WqGs2wVwpQwIXltb1M0v Content-Type: text/x-patch; charset=UTF-8; name="format.patch" Content-Disposition: attachment; filename="format.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL3N0ZC9mb3JtYXQgYi9saWJzdGRj KystdjMvaW5jbHVkZS9zdGQvZm9ybWF0CmluZGV4IGY0ZmM4NWExNmQyLi45ZjViN2JlZTJi ZSAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL2luY2x1ZGUvc3RkL2Zvcm1hdAorKysgYi9s aWJzdGRjKystdjMvaW5jbHVkZS9zdGQvZm9ybWF0CkBAIC0xNTM3LDcgKzE1MzcsNyBAQCBu YW1lc3BhY2UgX19mb3JtYXQKIAogCSAgICAgIGlmIChfX3RyYWlsaW5nX3plcm9zKQogCQl7 Ci0JCSAgaWYgKCFpc3hkaWdpdChfX3NbMF0pKQorCQkgIGlmICghc3RkOjppc3hkaWdpdChf X3NbMF0pKQogCQkgICAgLS1fX3NpZ2ZpZ3M7CiAJCSAgX196ID0gX19wcmVjIC0gX19zaWdm aWdzOwogCQl9CkBAIC0xNjI3LDcgKzE2MjcsNyBAQCBuYW1lc3BhY2UgX19mb3JtYXQKIAkJ ewogCQkgIF9fZmlsbF9jaGFyID0gX0NoYXJUKCcwJyk7CiAJCSAgLy8gV3JpdGUgc2lnbiBi ZWZvcmUgemVybyBmaWxsaW5nLgotCQkgIGlmICghaXN4ZGlnaXQoX19uYXJyb3dfc3RyWzBd KSkKKwkJICBpZiAoIXN0ZDo6aXN4ZGlnaXQoX19uYXJyb3dfc3RyWzBdKSkKIAkJICAgIHsK IAkJICAgICAgKl9fb3V0KysgPSBfX3N0clswXTsKIAkJICAgICAgX19zdHIucmVtb3ZlX3By ZWZpeCgxKTsK --------------hYk6WqGs2wVwpQwIXltb1M0v--