From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9DE813858282; Tue, 23 Apr 2024 06:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DE813858282 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DE813858282 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713855086; cv=none; b=J4YzJD6hUc7pHdbTnjxCKaOtUKo3qV5oPH9muIwtw+51Yruk6J4+ZdmYKwMaIIMI8ZxZhqIWdYM/JODutc2TnRDQdA74gfVKcFx+LKisyJfa1mulex2vi8Lr8yrEi2W3X6exA8e4svNW3bypts4CWH0u6d/q816vL3ffd4SbFgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713855086; c=relaxed/simple; bh=eBUwK3XTbUxDfEn2byY1mj+ePKy2/VSsN5/q1c9T1WQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=ql+mr97gHLiHSqVMJdVRJ0A3H8h9BURd6kOdbUGsgGVVH8IACW9EUFv4Nl/0NjFTlBmq/ae7dqztiZnzvPp3AqBzumqXHxOJ9EIkfqdFGxOi8W4ATw8AhZ/qbJvjriDdrSCw9UJlpS26pIgqKB+Jd73CGG9H7Uv+E/5NE0Y+KrQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43N5Ul8N014547; Tue, 23 Apr 2024 06:51:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Pr1m4P9huyOtlEPVGvOZAGcEysu9TUr4C0KKuu0Dn28=; b=EKZolb72WfrmTeBBTexlquxdQAj1X+qB/vqCAASE29q+gV3c/67sMfbiLU4SqACFCV2V kjy2TD9Aex1C17m6EDcXsGuROpuLfNbhTApE+15ynpkE3u+O/czUbwzUD87qrQg5OtdF u0VmcexdNWSV1bwLYjUKZRxYWf3YDAMO1SbY4EC3Ob8CU4PkKXPBJG0PA0QpE8hEI2Yf GoJIbL/Gp+mH1HUId0Hukn9tRXsOQHwnLWeBU4AGxLe6RdQV3EzyNVB01DUppAtyLqzG iW0+obgSdcB/T9zqqyQL5WDJeWnfyjyctvxh1H3mhfRGLB135Asm5C4+GP1NOZofXGZ2 Aw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xp4vr87x1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 06:51:22 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43N6pJRc017737; Tue, 23 Apr 2024 06:51:21 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xp4vr87wy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 06:51:21 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43N5HnHs005384; Tue, 23 Apr 2024 06:51:20 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xmx3cavmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 06:51:20 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43N6pHpj44368238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2024 06:51:19 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C6E92004D; Tue, 23 Apr 2024 06:51:17 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A130920040; Tue, 23 Apr 2024 06:51:14 +0000 (GMT) Received: from [9.200.55.181] (unknown [9.200.55.181]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 23 Apr 2024 06:51:14 +0000 (GMT) Message-ID: Date: Tue, 23 Apr 2024 14:51:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] ppc: testsuite: vec-mul requires vsx runtime Content-Language: en-US To: Alexandre Oliva Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , gcc-patches@gcc.gnu.org References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DmS3RjZmG8M8PYdiusBi1-Vu2C2C7q_s X-Proofpoint-ORIG-GUID: mE74U1CXguGDwQ3Mfdmy5Dfp68sZPSiT Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_04,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404230019 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: on 2024/4/22 17:35, Alexandre Oliva wrote: > Ping? > https://gcc.gnu.org/pipermail/gcc-patches/2022-May/593947.html > > > vec-mul is an execution test, but it only requires a powerpc_vsx_ok > effective target, which is enough only for compile tests. In order to > To check for runtime and execution environment support, we need to > require vsx_hw. Make that a condition for execution, but still > perform a compile test if the condition is not satisfied. > > Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with > gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.target/powerpc/vec-mul.c: Run on target vsx_hw, just > compile otherwise. > --- > gcc/testsuite/gcc.target/powerpc/vec-mul.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/powerpc/vec-mul.c b/gcc/testsuite/gcc.target/powerpc/vec-mul.c > index bfcaf80719d1d..11da86159723f 100644 > --- a/gcc/testsuite/gcc.target/powerpc/vec-mul.c > +++ b/gcc/testsuite/gcc.target/powerpc/vec-mul.c > @@ -1,4 +1,5 @@ > -/* { dg-do run } */ > +/* { dg-do compile { target { ! vsx_hw } } } */ > +/* { dg-do run { target vsx_hw } } */ > /* { dg-require-effective-target powerpc_vsx_ok } */ Nit: It's useless to check powerpc_vsx_ok for vsx_hw, so powerpc_vsx_ok check can be moved to be with ! vsx_hw. OK with this nit tweaked, thanks! BR, Kewen > /* { dg-options "-mvsx -O3" } */ > > >