From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 01C7B384AB6D for ; Mon, 22 Apr 2024 17:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01C7B384AB6D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01C7B384AB6D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713806451; cv=none; b=QUxwDvB702N1JlFZ/BH5vd9LRue/H72/0ex9TGpH9r+zOMYwuL2XaoUW5uJjMOAr24KTq/C0ZJRlnqMbJaPRj4OWcuyirvA1eKv+gEC+dJm1urzkC+K+kn0PZOU9FZgBIEe0Dd1XT8spUTb/D1RK1cc9VGQPtdXLCie+ueu30uo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713806451; c=relaxed/simple; bh=llyP7YIEqI6L2mjgCNuXqr6a6NXXHArBaVUwOVPXv+0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=vuzKxrzpmx86nF+i0QRcYffkhcaTymEKzAQ4FEfcgAC/v/GT5J/FyRVWIbsLyuHv30hec0N4rnEdmVNVi52lsfssDnQIP9pqO1KHj1hfeO3DtzFXQrll6tcOeHyCAW6rLzVOtWHOKxDbhzYvUxBZKsfY+v91oM04XaJ2PmX/8Lg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6ed01c63657so4085853b3a.2 for ; Mon, 22 Apr 2024 10:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713806448; x=1714411248; darn=gcc.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=hPh+xPsL6NevO8+1RowKYx2rxEOVNfrYP8UfWBk1f2Q=; b=LKLQMYoMltXNiqOexH4ys55g075Yzpm2jGsb8uyrJNJcxaABkWDOM4b/jiOZQVMAk0 mlBEYHGQN+qYStvhveMAVSqzCYlDi8fmfXOAR3DEdJAy1Yv5hOJeEqin8b6ORR5fO9+1 MMp0FYBTTeahc/jFZnxSqFZeyTAx2VT63rDNrFP117daTiDLft1sr2eBhjUz/36uvqps g/y8beT9//cPsDyOqR2jfPk8Fkd4IJHR1vFS8otEgv/t/Sg38eq4HiKuy9BuarPfouRq JcNK4fLBou0Ev/qTdllIBuqK6AH3YfgypisTKQlNaKuCNQz0juonUy6OqGDo+cLRK3hz P3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713806448; x=1714411248; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hPh+xPsL6NevO8+1RowKYx2rxEOVNfrYP8UfWBk1f2Q=; b=g+URkkCixeK0YLlJElLkdmu/IJrz9bmPW71V6ZhpNXmJm67r/0j8qVtC2s1ZYVxwIE GImDOZhogRrURCJBm2NRlAZ6JmC21ZP0PaD2YL/xj08088HuTq6WP/Udl2Ji16gzNW1J a5ztLCAg9xGksyCj8NKOgCdBCMBbRGPp5oHmk7e/Do6YfgQs3bHFRne7ShP1bfVGcI2H uVCVDqdkTgciEHeebdF1tihHoeqdyLOTA7tLntKLvjI71ddRzq6T+RjyTMXnbsz4DTSO yorem2uPYlYxwsUQGkscsVesYuzVfyA0jWwps9VX2VCqh2YP/GF5vdb2n1ZqxRvosknM TqDQ== X-Forwarded-Encrypted: i=1; AJvYcCWF3M2WXYnP+1E55W3uxO1/8tI3ebBHs2D7Rybr0GUs8CnGoSAO30Ckrf2c3Iaa3vGjFG+b+9uspSr83LcjC//bbxHqHdAMFg== X-Gm-Message-State: AOJu0YxMTKdA9scrrI5rZKphgn9qJYx/IGkKM6XtTFquHLuw7uj+OwfK Tv7zKItF6Zo79P0II4KVWRXYZH2ugRLHT+xLGw6HaIFSawf1TCxImpIO8nULOm4= X-Google-Smtp-Source: AGHT+IEj38vSlhRuiQUO9e4HMTnuAo3Yl6WK0MxeKI7OjELCUAKxs1cG768rSezvyD/9tE8HRNtB/g== X-Received: by 2002:a05:6a20:430f:b0:1ac:3660:4831 with SMTP id h15-20020a056a20430f00b001ac36604831mr12601954pzk.1.1713806447693; Mon, 22 Apr 2024 10:20:47 -0700 (PDT) Received: from [10.0.17.156] ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id c24-20020aa78818000000b006f319bdcfbesm896634pfo.132.2024.04.22.10.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Apr 2024 10:20:47 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------yC0KKyjrlPZdYnnxQ6JCeMbQ" Message-ID: Date: Mon, 22 Apr 2024 10:20:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] RISC-V: Revert RVV wv instructions overlap and xfail tests To: "Li, Pan2" , Robin Dapp , "gcc-patches@gcc.gnu.org" Cc: "juzhe.zhong@rivai.ai" , "kito.cheng@gmail.com" References: <20240419142901.1585821-1-pan2.li@intel.com> <102e32cd-a6ff-47dc-b054-5c87638eb161@gmail.com> Content-Language: en-US From: Patrick O'Neill In-Reply-To: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------yC0KKyjrlPZdYnnxQ6JCeMbQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pan, >> I'm not sure I'm following. Did we miss something that should have been >> covered? Like only an overlap on the srcs but not the dest? >> Are there testcases that fail? If so we should definitely have one. Can you give some additional information on why these reverts are needed? +1 to the request for a failing testcase if there is one.Patrick >> If something is broken then indeed we should revert it. > Yes, we may need to support these in gcc-15. > >> ... why not just revert everything and xfail all the tests in a >> follow up? Your patch is essentially a revert but doesn't look like >> it. I'd rather we let a revert be a revert and adjust the tests >> separately so it becomes clear. > Sure, will revert b3b2799b872 and then file the patch for the xfail tests. > > Pan --------------yC0KKyjrlPZdYnnxQ6JCeMbQ--