From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2C38F385DDD5 for ; Tue, 25 Jun 2024 13:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C38F385DDD5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2C38F385DDD5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719321811; cv=none; b=b/9wP079k8QamlteuCPo9+2OvfNwq0chwMVN7pRQwi3CikLi5Pz+Ijpe6Uvhjnxu/Q7KnlFgbLwNzVWT7drCFW4HDW2jGIG3UxedzyJ9q979vNNS2sVQXEDAQ0wwz0aqV5XBSIGKOAPTz5yBqk53V59nq1fvOrnJ9qGshlG4r/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719321811; c=relaxed/simple; bh=NIRyoIAO4ejW4CRFswTseBXeiLf3I+qV87htQ7XdkvY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xmOV+oUg2Bd85twIlUVdWdK613wOAAR8fY4h7VUnNsTCCL1CvISB8yvL0fhb6hIi6yBJJ88iiYgxER5bCDC31UZUOj0CUGxbBBVrliN0mP7CvyuzVlmHvGSCVzqaozWsSYpwVJU8d3vBwzGLtXOwyBfh20BXjluougqODfS0oCw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719321808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X6yRBcCagf3xf0JArv6kwhOFve7roPCvMNRBDpXZESs=; b=M6HQeIZNUNTeQy1tda7rvqXiy/xnMrc2MYh3AXbcUZx1WCM/9Ijx9JztyO7jqf6bs7i9oj wfAtGrSzU9VO0V3cYTDq0Q60+AhJJSzcNgmm5Y+0gF6Xa6OmAulamXa+3ikV/nE7OrcwEv Aak6Xjr4eRavT7v+SVhBH6qbT3T5c5g= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-YE_GSoDJP-214H8D0ieMYQ-1; Tue, 25 Jun 2024 09:23:25 -0400 X-MC-Unique: YE_GSoDJP-214H8D0ieMYQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6b50433add5so86009376d6.3 for ; Tue, 25 Jun 2024 06:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719321805; x=1719926605; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X6yRBcCagf3xf0JArv6kwhOFve7roPCvMNRBDpXZESs=; b=puNopfxBKTqFxhG8tivnbywZ0wTjHMYDNh2DNS4AtrYpvjFJcI+5c+FFx3H2ov3CQ9 4ObnJG6txqU3F84qzPm5mH89Eslpk2khS/si6jHmu/gFf2blzwmpjzokXdkJVb6m9cO5 M5hLXa9f1EkRALFq31Z7bSNGY596CrNiE21Ct9oktdIFiUzEzVX3LYLKhrtADWqzZu7L OwkNeRwLtCV8QTOYdgmjFfyCyt1Z+G1tSCkj24HgiUB5hmvgKQMgAYIlnkGR5L6Urkya WdReJ0P6WLcurMPsA/BHpL4BJjy1dh8kuloVPiWWzZeZ1OivaFV7xspPCbVQHRNbPNW6 THnw== X-Forwarded-Encrypted: i=1; AJvYcCUTm/ZnbGRaPOdjkkUybqiKS5CDF/Tzm2en02uWPRFpGSlJ6LO8qG3MQ3n0aNtc16Zl1QPAwY14T/lIQKeII9Ag/1t5RR3cuA== X-Gm-Message-State: AOJu0Yze8krZy/gTMKhrOMxe+6nSuMjoMOS4Fi4ih3W6oYzf11sg0Koe s9flktLPw4zA1odP+Mt0kqq1bUdizNYKDd0G3r/U6zzlRlKRPltqasfBbc4/nHxQAZg5OkJ0sjR bN5wpnKEQqeJojVoWhZVWK4r3hTXv+Sgg6MVWNKkEJBr4zV5XyXg6rxc= X-Received: by 2002:a0c:c210:0:b0:6b0:7a5c:e12c with SMTP id 6a1803df08f44-6b53bbb871fmr69759626d6.29.1719321804889; Tue, 25 Jun 2024 06:23:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXH82QOoU1ur+FtGUGmHOd2xYga7/0Xk+/2eP8Eyn33earJDp5pZ5RB1qlXfqAs0FHzeYnvA== X-Received: by 2002:a0c:c210:0:b0:6b0:7a5c:e12c with SMTP id 6a1803df08f44-6b53bbb871fmr69759436d6.29.1719321804515; Tue, 25 Jun 2024 06:23:24 -0700 (PDT) Received: from ?IPV6:2607:fea8:51de:a700::8e40? ([2607:fea8:51de:a700::8e40]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ef6e795sm43507426d6.141.2024.06.25.06.23.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 06:23:24 -0700 (PDT) Message-ID: Date: Tue, 25 Jun 2024 09:23:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add param for bb limit to invoke fast_vrp. To: Andrew Pinski Cc: Richard Biener , gcc-patches , "hernandez, aldy" References: <1bb04945-d13b-4805-b9ed-0be4a5c773fc@redhat.com> <3ee2acc2-24ca-4739-9864-01e7457a5327@redhat.com> From: Andrew MacLeod In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/24/24 22:35, Andrew Pinski wrote: > On Mon, Jun 24, 2024 at 7:20 PM Andrew MacLeod wrote: >> // Fill ssa-cache R with any outgoing ranges on edge E, using QUERY. >> bool gori_on_edge (class ssa_cache &r, edge e, range_query *query = >> NULL); >> >> This is what the fast_vrp routines uses. We can gather all range >> restrictions generated from an edge efficiently just once and then >> intersect them with a known range as we walk the different paths. We >> don't need the gori exports , nor any of the other on-demand bits where >> we calculate each export range dynamically.. I suspect it would reduce >> the workload and memory impact quite a bit, but I'm not really familiar >> with exactly how the threader uses those things. >> >> It'd require some minor tweaking to the lazy_ssa_cache to make the >> bitmap of names set accessible. This would provide similar >> functionality to what the gori export () routine provides. Both >> relations and inferred ranges should only need to be calculated once per >> block as well and could/should/would be applied the same way if they are >> present. I don't *think* the threader uses any of the def chains, but >> Aldy can chip in. > + warning (OPT_Wdisabled_optimization, > + "Using fast VRP algorithm. %d basic blocks" > + " exceeds %s%d limit", > + n_basic_blocks_for_fn (fun), > + "--param=vrp-block-limit=", > + param_vrp_block_limit); > > This should be: > warning (OPT_Wdisabled_optimization, "Using fast VRP algorithm. %d basic blocks" > " exceeds %<%--param=vrp-block-limit=d%> limit", > n_basic_blocks_for_fn (fun), param_vrp_block_limit); > > I had thought it was mentioned that options should be quoted but it is > not mentioned in the coding conventions: > https://gcc.gnu.org/codingconventions.html#Diagnostics > > But it is mentioned in > https://inbox.sourceware.org/gcc/2d2bd844-2de4-ecff-7a07-b2235075074c@gmail.com/ > ; This is why you were getting an error as you mentioned on IRC. > > I didnt do that because when I did, everything in bracketed by the %< %> in the warning came out in bold text.  is that the intended effect? Andrew.