From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 38D773858C50 for ; Thu, 29 Sep 2022 09:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38D773858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,354,1654588800"; d="scan'208,217";a="83828091" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 29 Sep 2022 01:23:07 -0800 IronPort-SDR: eCX2uML3vw4daQdomzwAq1LcFkgMG8X4FytwYZj1xAV6cLeGK+Jj/gJ85TurTOvGkqAGNtDpBS syEOXCbhQJl576Zy9qSFpJwwaGNmIA5/E06bJmkV4GsmsjkbpiLXm1Ar4YghvsfhATrlICNU5c KvMa7Zfyx3DysxN3hg/P0WVeFo3CGbfZjT56MH19RfJCP0FKXRaWCFZT9zV4EiXXHMWgOPJKI9 dhtsJr0HogBmRdX2HZmti5IOmSLe7ghP8HYutHJWyuPz3Vkv1qcSfzE09194tk3Zaqw+Ymw1vU nuI= Content-Type: multipart/alternative; boundary="------------WdsfX06Q3xgdVi3RH0C0kBaF" Message-ID: Date: Thu, 29 Sep 2022 11:23:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] driver, cppdefault: Unbreak bootstrap on Debian/Ubuntu [PR107059] Content-Language: en-US To: Jakub Jelinek , Richard Biener , Jason Merrill , "Joseph S. Myers" CC: References: From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------WdsfX06Q3xgdVi3RH0C0kBaF Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 29.09.22 09:06, Jakub Jelinek wrote: My recent change to enable _Float{16,32,64,128,32x,64x,128x} for C++ apparently broke bootstrap on some Debian/Ubuntu setups. Those multiarch targets put some headers into /usr/include/x86_64-linux-gnu/bits/ etc. subdirectory instead of /usr/include/bits/. ... Bootstrapped/regtested on x86_64-linux (Debian on GCCFarm, though with the /usr/include/bits -> x86_64-linux-gnu/bits symlink). Ok for trunk? I have now bootstrapped on ppc64le with Ubuntu 18.04.3 LTS (bionic) with gl= ibc 2.27-3ubuntu1 This glibc is too old for the '# if __LDBL_MANT_DIG__ =3D=3D 113"' issue = reported by Joseph as that line was added one version later in glibc 2.28. But it did have the bootstrap issue (only affecting the -B... / build, the = installed one was okay - for reasons why, see PR). Thus, my boostrap only tested this patch - and not the __LDBL_MANT_DIG__ pa= rt. Result: Bootstrapping passed and I get for cd $BUILD echo '#include ' > foo.c gcc/xgcc -B`pwd`/gcc -v -E -o foo.i foo.c grep floatn.h foo.i ... /tmp/gcc-build/gcc/cc1 ... \ -iprefix /tmp/tburnus-gcc-test/gcc/../lib/gcc/powerpc64le-unknown-linux-g= nu/13.0.0/ \ -isystem /tmp/tburnus-gcc-test/gcc/include \ -isystem /tmp/tburnus-gcc-test/gcc/include-fixed/powerpc64le-linux-gnu \ -isystem /tmp/tburnus-gcc-test/gcc/include-fixed ... #include "..." search starts here: #include <...> search starts here: /tmp/gcc-build/gcc/include /tmp/gcc-build/gcc/include-fixed/powerpc64le-linux-gnu /tmp/gcc-build/gcc/include-fixed /usr/local/include /usr/include/powerpc64le-linux-gnu /usr/include End of search list. ... # 1 "/tmp/gcc-build/gcc/include-fixed/powerpc64le-linux-gnu/bits/floatn.h" = 1 3 4 * * * And with the installed version: #include "..." search starts here: #include <...> search starts here: /tmp/gcc-inst/lib/gcc/powerpc64le-unknown-linux-gnu/13.0.0/include /usr/local/include /tmp/gcc-inst/include /tmp/gcc-inst/lib/gcc/powerpc64le-unknown-linux-gnu/13.0.0/include-fixed/p= owerpc64le-linux-gnu /tmp/gcc-inst/lib/gcc/powerpc64le-unknown-linux-gnu/13.0.0/include-fixed /usr/include/powerpc64le-linux-gnu /usr/include End of search list. ... # 1 "/tmp/gcc-inst/lib/gcc/powerpc64le-unknown-linux-gnu/13.0.0/include-fix= ed/powerpc64le-linux-gnu/bits/floatn.h" 1 3 4 ... Thanks for the fix! Tobias 2022-09-29 Jakub Jelinek PR bootstrap/107059 * cppdefault.cc (cpp_include_defaults): If SYSROOT_HEADERS_SUFFIX_S= PEC isn't defined, add FIXED_INCLUDE_DIR entry with multilib flag 2 before FIXED_INCLUDE_DIR entry with multilib flag 0. * gcc.cc (do_spec_1): If multiarch_dir, add include-fixed/multiarch_dir paths before include-fixed paths. ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------WdsfX06Q3xgdVi3RH0C0kBaF--