From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id D9774385829F for ; Fri, 5 Aug 2022 15:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9774385829F Received: by mail-pj1-x102a.google.com with SMTP id h21-20020a17090aa89500b001f31a61b91dso8591360pjq.4 for ; Fri, 05 Aug 2022 08:27:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=F7uN9UzcA06QTCyRVfGgsviCHe94BU0JC6Liu55xqqg=; b=giYR7rgXKSMFH1v+o3nBHVA1SvWhyCCyHUT8au4hnoIPa2gcCyTsyjpYg+Ju9mFkdC BD3dNjhkVkB4TZRDb8AOwCyhkuj31wPffsWYLNAVoAB1wbeo+b7wQMMylf2HRbkXGrLX 6IzuBjPEaYdqxk/Ezd3LURGpE4j4FCO2vCbZ38WFmlUC+OB2F3qnoS8uYbeVFlm4W4gZ Q4FWbAdyUc/R6Akj/oiErS34PErqbXlOIIbomhwMTexUGsAcmQBeYWoDZfypukbDLc4e tj54URLZAVYWEaRr81ByEOYzE8HhK0Ae8j7zyx66KikwncHbcJa/2BoE8KW7HuFlOZNF +5Bw== X-Gm-Message-State: ACgBeo2umMc6n484/Uwz0koHMIBdQ8Rmk2wJibNK9h2kFQoXC01C0IEv X0IyLNGpxPacIOWN6gxfAZKFn1pdy1E= X-Google-Smtp-Source: AA6agR7sfYpc++0qFso7KnrD5PmNafxGMOTHcRLxaOxAlf3JzjKP4dW2BwHBfFlHaQXBJc3Et3FAEg== X-Received: by 2002:a17:90a:d789:b0:1f5:1c76:24d6 with SMTP id z9-20020a17090ad78900b001f51c7624d6mr8164675pju.188.1659713264273; Fri, 05 Aug 2022 08:27:44 -0700 (PDT) Received: from [172.31.0.204] (c-73-98-188-51.hsd1.ut.comcast.net. [73.98.188.51]) by smtp.gmail.com with ESMTPSA id kk1-20020a17090b4a0100b001f216407204sm3219870pjb.36.2022.08.05.08.27.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 08:27:43 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 09:27:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] backthreader dump fix Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220805123156.8F62313A9C@imap2.suse-dmz.suse.de> From: Jeff Law In-Reply-To: <20220805123156.8F62313A9C@imap2.suse-dmz.suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SCC_BODY_URI_ONLY, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2022 15:27:47 -0000 On 8/5/2022 6:31 AM, Richard Biener via Gcc-patches wrote: > This fixes odd SUCCEEDED dumps from the backthreader registry that > can happen even though register_jump_thread cancelled the thread > as invalid. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. > > * tree-ssa-threadbackward.cc (back_threader::maybe_register_path): > Check whether the registry register_path rejected the path. > (back_threader_registry::register_path): Return whether > register_jump_thread succeeded. LGTM. jeff