From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4F9353858D37; Thu, 1 Dec 2022 03:31:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4F9353858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B12g349003837; Thu, 1 Dec 2022 03:31:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=KhivBSnXPsMkK9Sf7vDCzhRGGcJs/enGN4NAgpCO72E=; b=rkBnw7C5ju6+xRSUcrm21YN8Viz/Kfb5SKI6nPjpr2EXmEQXL18hfI98OLKeUK1zDrjz 1j7kKVM4Y0qT07tTepOJa0Kyy/x8yLrg0AMNFh0K2+K9x33OwgQDt/nybqD+x+QRv0t8 nUWGElsBRTs1I4cB4s72d7qi+AcFCoIc4A87GRrbROxvCbAJU7XXPWtWe0wzlqX7P0PN JpT7BCKQ4Z6fuN2gB+AQZ+14heNSfo6EQCzW6d3c+PRysYokw4kiSaPJqJJLi4r2w+4U 2DCDtR9AR5sVeQZFMtOAtwsgVbguwIZonEtymNXKf9X0UD+S0+iMd/jdVHtdP2a20sVY JQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6kq9gyas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 03:31:14 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B13VEHr031731; Thu, 1 Dec 2022 03:31:14 GMT Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6kq9gya4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 03:31:14 +0000 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2B13KFsv021922; Thu, 1 Dec 2022 03:31:11 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma03fra.de.ibm.com with ESMTP id 3m3ae8vvcq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 03:31:11 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B13V9kk11534868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Dec 2022 03:31:09 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FBE5A405B; Thu, 1 Dec 2022 03:31:09 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87146A4054; Thu, 1 Dec 2022 03:31:07 +0000 (GMT) Received: from [9.197.236.127] (unknown [9.197.236.127]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 1 Dec 2022 03:31:07 +0000 (GMT) Message-ID: Date: Thu, 1 Dec 2022 11:31:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3]rs6000: NFC no need copy_rtx in rs6000_emit_set_long_const and rs6000_emit_set_const Content-Language: en-US To: Jiufu Guo Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20221201013619.196004-1-guojiufu@linux.ibm.com> <20221201013619.196004-3-guojiufu@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <20221201013619.196004-3-guojiufu@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: FnXl_GBS5bCm5E99xW1d5VdQIBFoR8xj X-Proofpoint-GUID: 30D54IIfm43Or0JLGM5OOzejcIGXgqUq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-01_02,2022-11-30_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 mlxscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212010020 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, on 2022/12/1 09:36, Jiufu Guo wrote: > Hi, > > Function rs6000_emit_set_const/rs6000_emit_set_long_const are only invoked from > two "define_split"s where the target operand is limited to gpc_reg_operand or > int_reg_operand, then the operand must be REG_P. > And in rs6000_emit_set_const/rs6000_emit_set_long_const, to create temp rtx, > it is using code like "gen_reg_rtx({S|D}Imode)", it must also be REG_P. > So, copy_rtx is not needed for temp and dest. > > This patch removes those "copy_rtx" for rs6000_emit_set_const and > rs6000_emit_set_long_const. > > Bootstrap & regtest pass on ppc64{,le}. > Is this ok for trunk? This patch is okay, thanks! For the subject, IMHO it's better to use something like: "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const". I don't see NFC tag used much in GCC, though it's used a lot in llvm, but anyway you can append (NFC)/[NFC] at the end if you like. :) BR, Kewen