From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 58785384D1BE for ; Fri, 24 Jun 2022 13:55:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 58785384D1BE Received: by mail-pj1-x102c.google.com with SMTP id dw10-20020a17090b094a00b001ed00a16eb4so2904298pjb.2 for ; Fri, 24 Jun 2022 06:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=sNwbbvCjgQ6QKuO9fPupchuDf9lCvwORCjShzbjeiwU=; b=Ca6EtPEgoIz+gG1u2/UBM8ItFRPXfjV4Rh6AOfbCiZBtSVTZsFluXqA5T+WJ/XpiVU 27H0PClTP0Xc43arCR74a9JioWHGhyAVAF4dFy36xVebLEDHJhAxLZCGwdoW/Yal13O1 aBWYBKCWqo+ERNfMM4v3O9apbUgpGOkivoUQQsu8i9Yta7iF0kMsqwpxkp+0kQUREp7p almS6mWEviAvGaD5e0Cd6BEmMl8xazj07YmSvFuFWdA8TZkx3cgeiiN6LO/7zAJIQRrC VTov1b9cTD52xpF6LqQHlWFdKciDEU0PetlmM752JGdKJrzLKIaxA7KHhkdUKVxE2Usk JA8g== X-Gm-Message-State: AJIora9j6aFFy9num++f4UMnJPhzaGoQTtuenQAMDvjShRUIfS7lRHRk Ccoz80VdZwCavFVZcGFeED4RG0kSYXc= X-Google-Smtp-Source: AGRyM1sr68NVTa+o+g8hBuaW7RrB5lCcbHNkd6xkX4KWLRGzp44Z6d8vi2xUa9mfXkGA/j/9jINBtA== X-Received: by 2002:a17:90b:1c11:b0:1e7:8bd2:697d with SMTP id oc17-20020a17090b1c1100b001e78bd2697dmr4313825pjb.90.1656078928917; Fri, 24 Jun 2022 06:55:28 -0700 (PDT) Received: from [172.31.0.204] (c-73-63-24-84.hsd1.ut.comcast.net. [73.63.24.84]) by smtp.gmail.com with ESMTPSA id y13-20020a17090a474d00b001ec92c52285sm1818071pjg.21.2022.06.24.06.55.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 06:55:28 -0700 (PDT) Message-ID: Date: Fri, 24 Jun 2022 07:55:27 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Enable some features for RTEMS in libstdc++ Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220623113929.22626-1-sebastian.huber@embedded-brains.de> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 13:55:32 -0000 On 6/24/2022 5:38 AM, Sebastian Huber wrote: > On 23.06.22 13:39, Sebastian Huber wrote: >> Remove RTEMS support from crossconfig.m4 since this code is not used >> due to >> "with_newlib" being "yes". >> >> libstdc++-v3/ChangeLog: >> >>     * configure: Regnerate. >>     * configure.ac (newlib, *-rtems*): Enable TLS support for all RTEMS >>     targets except bfin, lm32, mips, moxie, or1k, and v850. >>     For all RTEMS targets, define HAVE_ALIGNED_ALLOC, >> HAVE_AT_QUICK_EXIT, >>     HAVE_LINK, HAVE_POLL, HAVE_QUICK_EXIT, HAVE_READLINK, HAVE_SETENV, >>     HAVE_SLEEP, HAVE_SOCKATMARK, HAVE_STRERROR_L, HAVE_SYMLINK, >>     HAVE_TRUNCATE, and HAVE_USLEEP. >>     * crossconfig.m4 (*-rtems*): Remove. > > Since this patch touches the global configure script and a > Newlib-specifc part, I guess I need approval from someone. Not really.  It's just hitting the rtems parts of those files which we've generally considered part of the port. Or to put it another way, who is likely in a better position to know if this is correct, you or someone like myself? :-) Jeff