From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 057D73858D35 for ; Sat, 21 Oct 2023 18:04:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 057D73858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 057D73858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697911473; cv=none; b=pKcDkwIa+7d6ajiKSiMhe7LLuOdsQHlUcZFVGMMkdCwzF+Dj+uTp84qZ6/8zg2daHn9wOa9joCkTl4lbGIsyhaadsu4VBx/TOaVUpF4Dud3P8JvYD0Y9oS47G7TbySwmKvVAWnSpPHTcJQISD2hRAfK6H+K3UI6CNXl2isweEP0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697911473; c=relaxed/simple; bh=Ma1BITyL7VFMFWKX+QC99EvCLM1Y7b6Ki3OvsWxeduo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tyONStYkPwuOdJvQ9kvEhkqSaze7LIb2XvFDj2f/n8QqdNrq+RoRpGpamA2bGsTTQATHMvG5V/xeNqHQXbK1uTP0tDltIGIbJZiXBEq3HZhI0ODD1fxA7k9upg4+qsJCrUW6CltBPkPPN4jBNVNWoxh65DShM7EEZ++oRMWhNmg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-27d5c71b4d7so2260514a91.1 for ; Sat, 21 Oct 2023 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697911462; x=1698516262; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HjyX4cVTh4a5gREAKeru8P5J+zkh/N4e4FojeIjwxB0=; b=JI/LljJLQgN5Y3fl6hg8rs72BpCKXWrD+TVjaXW4PM3EyR5/hKT5Fdl4BsJc+8rXMw NFX5wtVuaGblgVJHiJo9kwIJOlLAXrmhAdOmX7XXwI1evnqJULuZB9mHsfggF6QPSNb0 OxZRvXhkH6Qx6IwKAOzbEllgSDfN7Hr0hUAnbA3C6vokHEYucHRSqc3BzC60H6JzIWIg u0xHEhBt66apx/ufkP0geFu2wA1vWI0xQbXYJBwyqFDJP8VX+4G7uDDg7ASRPSsKZYnZ g5acm15rnRkDGBl5ye6a1QiqpaPim8ak3b8SK3hbcRseCevyU1XHB4jiXhbC/aWKOtpH uE0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697911462; x=1698516262; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HjyX4cVTh4a5gREAKeru8P5J+zkh/N4e4FojeIjwxB0=; b=M1DaVwaFwtgsLTNX2aiLdSma35Ml9RY8AbJeI3oaoYa6OD//wVYhL7VxgEWVHYUoTL HBXSZMk1K2fUw/TLehsR86NIA63fro/a5VoIkXHJAxkOD0RmcTbXMpZC53JaQZevtnYm AJY7pApyz8kpPFX78lFlN9EX+JYtDjdXMfBICyL5MT5nMP65TR04PM7Q8eK6kBk/53l7 SUPQrr3jimq7RyCtvkGODsDeukciu2K3GMog6oGF56tIjdUGSSqGRpBgqlVgGnt5WYY3 SBjOAd3z5XUB0G85GGLxwMWhKpM4SUhv37QGaSmmiHXn350MZ8+7cRYQIIWCTKIJJjQJ q+xg== X-Gm-Message-State: AOJu0YypQFIdZP6TDqSC0jwbSQwd3uCmaJcaUy+q4OdzH/4TKtPoWiyX r3nyALVPvNxRd5p2+wdrTx4= X-Google-Smtp-Source: AGHT+IEv1JGsDA+3MHU5YzJktnuGIa6Z9FvVQBhZJQtZDx9k4bk2Xy6w6KF4odM7duSgzr9RcsNHjg== X-Received: by 2002:a17:90b:23d6:b0:277:3565:30cf with SMTP id md22-20020a17090b23d600b00277356530cfmr11715416pjb.6.1697911461844; Sat, 21 Oct 2023 11:04:21 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id je17-20020a170903265100b001c728609574sm3472585plb.6.2023.10.21.11.04.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 11:04:21 -0700 (PDT) Message-ID: Date: Sat, 21 Oct 2023 12:04:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H' Content-Language: en-US To: Tsukasa OI , Kito Cheng , Palmer Dabbelt , Andrew Waterman , Jim Wilson Cc: gcc-patches@gcc.gnu.org References: <92fad87801003eaa4cf9f47a1ab8d6e6f015ed12.1697866371.git.research_trasio@irq.a4lg.com> From: Jeff Law In-Reply-To: <92fad87801003eaa4cf9f47a1ab8d6e6f015ed12.1697866371.git.research_trasio@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/23 23:32, Tsukasa OI wrote: > From: Tsukasa OI > > According to the ratified privileged specification (version 20211203), > it says: > >> The hypervisor extension depends on an "I" base integer ISA with 32 x >> registers (RV32I or RV64I), not RV32E, which has only 16 x registers. > > Also in the latest draft, it also prohibits RV64E with the 'H' extension. > This commit prohibits the combination of 'E' and 'H' extensions. > > gcc/ChangeLog: > > * common/config/riscv/riscv-common.cc (riscv_subset_list::parse): > Prohibit 'E' and 'H' combinations. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/arch-26.c: New test. In a similar vein, GCC doesn't really care about the privileged extensions. So this won't really affect code generation. So I'll ACK, but going forward let's start doing the regression test. If you need help setting that up, I'm sure someone here can make suggestions. Personally I prefer a qemu+binfmt setup as it doesn't require setting up a board file and explicitly calling the simulator, ie, it looks a lot like native testing. jeff