From: Peter Bergner <bergner@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [PATCH, rs6000] Fix PR87496: ICE in aggregate_value_p at gcc/function.c:2046
Date: Thu, 29 Nov 2018 23:40:00 -0000 [thread overview]
Message-ID: <ab367267-f7b1-bad5-0cfd-5fb6d0ef6f95@linux.ibm.com> (raw)
In-Reply-To: <08b106d4-7bee-c067-5c37-755a8031d8e5@linux.ibm.com>
On 11/29/18 1:31 PM, Peter Bergner wrote:
> On 11/29/18 11:26 AM, Segher Boessenkool wrote:
>> On Wed, Nov 28, 2018 at 03:27:19PM -0600, Peter Bergner wrote:
>>> PR87496 shows a bug where we ICE if we attempt to use -mabi=ieeelongdouble
>>> and -mno-popcntd. The IEEE128 support requires full ISA 2.06 (aka POWER7)
>>> support, so we really should throw an error when using those options
>>> together. Ditto for -mabi=ieeelongdouble and -mno-vsx. The patch below
>>> does that.
>>>
>>> Ok for mainline once bootstrap and regtesting are complete and clean?
>>
>> Okay. Eventually we shouldn't allow selecting popcntd independently from
>> -mcpu=, but that day isn't here yet. So, okay for trunk, and backports
>> if wanted. Thanks!
>
> Ok, committed to mainline. It looks like GCC8 needs the same patch.
> I'll have to look closer at GCC7 on whether it needs it too, since the
> code seems to be a little different.
Ok, both GCC8 and GCC7 need the backport. I committed the backport
to GCC8 and will do the same for GCC7 once the freeze is over.
Peter
next prev parent reply other threads:[~2018-11-29 23:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 21:27 Peter Bergner
2018-11-29 2:11 ` Peter Bergner
2018-11-29 17:26 ` Segher Boessenkool
2018-11-29 19:31 ` Peter Bergner
2018-11-29 23:40 ` Peter Bergner [this message]
2018-12-04 19:43 ` Peter Bergner
2018-12-04 22:54 ` Segher Boessenkool
2018-12-07 17:38 ` Peter Bergner
2018-12-12 20:00 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab367267-f7b1-bad5-0cfd-5fb6d0ef6f95@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).