From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5308 invoked by alias); 26 Jul 2007 17:56:23 -0000 Received: (qmail 5293 invoked by uid 22791); 26 Jul 2007 17:56:22 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.177) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jul 2007 17:56:18 +0000 Received: by py-out-1112.google.com with SMTP id a29so1404851pyi for ; Thu, 26 Jul 2007 10:56:16 -0700 (PDT) Received: by 10.65.219.20 with SMTP id w20mr3587953qbq.1185472575885; Thu, 26 Jul 2007 10:56:15 -0700 (PDT) Received: by 10.64.142.18 with HTTP; Thu, 26 Jul 2007 10:56:15 -0700 (PDT) Message-ID: Date: Thu, 26 Jul 2007 18:47:00 -0000 From: "=?EUC-KR?B?U2VvbmdiYWUgUGFyayAoudq8urnoLCDa0+D328Yp?=" To: "Kenneth Zadeck" Subject: Re: [Bug middle-end/32749] [4.3 regression]: gfortran.dg/auto_array_1.f90 Cc: gcc-bugzilla@gcc.gnu.org, "Bonzini, Paolo" , gcc-patches In-Reply-To: <46A8DB68.9060508@naturalbridge.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_133412_5488993.1185472575815" References: <20070716232625.9422.qmail@sourceware.org> <46A88AB8.4000401@naturalbridge.com> <46A8DB68.9060508@naturalbridge.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-07/txt/msg01941.txt.bz2 ------=_Part_133412_5488993.1185472575815 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1325 On 7/26/07, Kenneth Zadeck wrote: > Seongbae Park (???, ???) wrote: > > On 7/26/07, Kenneth Zadeck wrote: > >> This patch extends the fix in > >> http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01557.html > >> to handle the case of clobbers inside conditional calls. > >> > >> This problem caused the regression of gfortran.dg/matmul_3.f90 on the > >> ia-64 in addition to the regression cited in this pr. > >> > >> Tested on ppc-32, ia-64 and x86-64. > >> > >> 2007-07-26 Kenneth Zadeck > >> > >> PR middle-end/32749 > >> > >> * df-problems.c (df_note_bb_compute): Handle case of clobber > >> inside conditional call. > >> > >> ok to commit? > > > > This change is OK. > > Though I wonder if we need to do similar checking > > for the regular insn case below. > No the checking is done in df_create_unused_note. The only reason you > have to do it here is that you are not calling that. > > thanks Now that I look at df_create_unused_note, this patch smells a bit - because the condition inside the for loop looks identical to df_create_unused_node. I think it would be cleaner if we split the live vector update into a separate function. i.e. attached patch (untested). -- #pragma ident "Seongbae Park, compiler, http://seongbae.blogspot.com" ------=_Part_133412_5488993.1185472575815 Content-Type: text/x-patch; name=pr32749.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f4ljqxyq Content-Disposition: attachment; filename="pr32749.patch" Content-length: 5287 ZGlmZiAtciBlNjZlYmZlYmRhZGMgZ2NjL2RmLXByb2JsZW1zLmMKLS0tIGEv Z2NjL2RmLXByb2JsZW1zLmMJV2VkIEp1bCAyNSAxODoxNDo1NyAyMDA3ICsw MDAwCisrKyBiL2djYy9kZi1wcm9ibGVtcy5jCVRodSBKdWwgMjYgMTA6NTU6 NDggMjAwNyAtMDcwMApAQCAtMzgzNSwzNyArMzgzNSwxNCBAQCBkZl9zZXRf ZGVhZF9ub3Rlc19mb3JfbXcgKHJ0eCBpbnNuLCBydHggCiAgIHJldHVybiBv bGQ7CiB9CiAKLQotLyogQ3JlYXRlIGEgUkVHX1VOVVNFRCBub3RlIGlmIG5l Y2Vzc2FyeSBmb3IgREVGIGluIElOU04gdXBkYXRpbmcgTElWRQotICAgYW5k IERPX05PVF9HRU4uICBEbyBub3QgZ2VuZXJhdGUgbm90ZXMgZm9yIHJlZ2lz dGVycyBpbiBhcnRpZmljaWFsCi0gICB1c2VzLiAgKi8KLQotc3RhdGljIHJ0 eAotZGZfY3JlYXRlX3VudXNlZF9ub3RlIChydHggaW5zbiwgcnR4IG9sZCwg c3RydWN0IGRmX3JlZiAqZGVmLCAKLQkJICAgICAgIGJpdG1hcCBsaXZlLCBi aXRtYXAgZG9fbm90X2dlbiwgYml0bWFwIGFydGlmaWNpYWxfdXNlcykKKy8q CisgKiBVcGRhdGUgdGhlIGxpdmUgdmVjdG9yIGdpdmVuIGEgZGVmLgorICov CisKK3N0YXRpYyB2b2lkCitkZl91cGRhdGVfbGl2ZV93aXRoX2RlZiAoc3Ry dWN0IGRmX3JlZiAqZGVmLCBiaXRtYXAgbGl2ZSwgYml0bWFwIGRvX25vdF9n ZW4pCiB7CiAgIHVuc2lnbmVkIGludCBkcmVnbm8gPSBERl9SRUZfUkVHTk8g KGRlZik7Ci0gIAotI2lmZGVmIFJFR19ERUFEX0RFQlVHR0lORwotICBpZiAo ZHVtcF9maWxlKQotICAgIHsKLSAgICAgIGZwcmludGYgKGR1bXBfZmlsZSwg IiAgcmVndWxhciBsb29raW5nIGF0IGRlZiAiKTsKLSAgICAgIGRmX3JlZl9k ZWJ1ZyAoZGVmLCBkdW1wX2ZpbGUpOwotICAgIH0KLSNlbmRpZgotCi0gIGlm ICghKGJpdG1hcF9iaXRfcCAobGl2ZSwgZHJlZ25vKQotCXx8IChERl9SRUZf RkxBR1MgKGRlZikgJiBERl9SRUZfTVdfSEFSRFJFRykKLQl8fCBiaXRtYXBf Yml0X3AgKGFydGlmaWNpYWxfdXNlcywgZHJlZ25vKQotCXx8IGRmX2lnbm9y ZV9zdGFja19yZWcgKGRyZWdubykpKQotICAgIHsKLSAgICAgIHJ0eCByZWcg PSAoREZfUkVGX0xPQyAoZGVmKSkgCi0gICAgICAgICAgICAgICAgPyAqREZf UkVGX1JFQUxfTE9DIChkZWYpOiBERl9SRUZfUkVHIChkZWYpOwotICAgICAg b2xkID0gZGZfc2V0X25vdGUgKFJFR19VTlVTRUQsIGluc24sIG9sZCwgcmVn KTsKLSNpZmRlZiBSRUdfREVBRF9ERUJVR0dJTkcKLSAgICAgIGRmX3ByaW50 X25vdGUgKCJhZGRpbmcgMzogIiwgaW5zbiwgUkVHX05PVEVTIChpbnNuKSk7 Ci0jZW5kaWYKLSAgICB9CiAgIAogICBpZiAoIShERl9SRUZfRkxBR1MgKGRl ZikgJiAoREZfUkVGX01VU1RfQ0xPQkJFUiArIERGX1JFRl9NQVlfQ0xPQkJF UikpKQogICAgIGJpdG1hcF9zZXRfYml0IChkb19ub3RfZ2VuLCBkcmVnbm8p OwpAQCAtMzg3Myw2ICszODUwLDM4IEBAIGRmX2NyZWF0ZV91bnVzZWRfbm90 ZSAocnR4IGluc24sIHJ0eCBvbGQKICAgLyogS2lsbCB0aGlzIHJlZ2lzdGVy IGlmIGl0IGlzIG5vdCBhIHN1YnJlZyBzdG9yZSBvciBjb25kaXRpb25hbCBz dG9yZS4gICovCiAgIGlmICghKERGX1JFRl9GTEFHUyAoZGVmKSAmIChERl9S RUZfUEFSVElBTCB8IERGX1JFRl9DT05ESVRJT05BTCkpKQogICAgIGJpdG1h cF9jbGVhcl9iaXQgKGxpdmUsIGRyZWdubyk7Cit9CisKKy8qIENyZWF0ZSBh IFJFR19VTlVTRUQgbm90ZSBpZiBuZWNlc3NhcnkgZm9yIERFRiBpbiBJTlNO IHVwZGF0aW5nIExJVkUKKyAgIGFuZCBET19OT1RfR0VOLiAgRG8gbm90IGdl bmVyYXRlIG5vdGVzIGZvciByZWdpc3RlcnMgaW4gYXJ0aWZpY2lhbAorICAg dXNlcy4gICovCisKK3N0YXRpYyBydHgKK2RmX2NyZWF0ZV91bnVzZWRfbm90 ZSAocnR4IGluc24sIHJ0eCBvbGQsIHN0cnVjdCBkZl9yZWYgKmRlZiwgCisJ CSAgICAgICBiaXRtYXAgbGl2ZSwgYml0bWFwIGFydGlmaWNpYWxfdXNlcykK K3sKKyAgdW5zaWduZWQgaW50IGRyZWdubyA9IERGX1JFRl9SRUdOTyAoZGVm KTsKKyAgCisjaWZkZWYgUkVHX0RFQURfREVCVUdHSU5HCisgIGlmIChkdW1w X2ZpbGUpCisgICAgeworICAgICAgZnByaW50ZiAoZHVtcF9maWxlLCAiICBy ZWd1bGFyIGxvb2tpbmcgYXQgZGVmICIpOworICAgICAgZGZfcmVmX2RlYnVn IChkZWYsIGR1bXBfZmlsZSk7CisgICAgfQorI2VuZGlmCisKKyAgaWYgKCEo Yml0bWFwX2JpdF9wIChsaXZlLCBkcmVnbm8pCisJfHwgKERGX1JFRl9GTEFH UyAoZGVmKSAmIERGX1JFRl9NV19IQVJEUkVHKQorCXx8IGJpdG1hcF9iaXRf cCAoYXJ0aWZpY2lhbF91c2VzLCBkcmVnbm8pCisJfHwgZGZfaWdub3JlX3N0 YWNrX3JlZyAoZHJlZ25vKSkpCisgICAgeworICAgICAgcnR4IHJlZyA9IChE Rl9SRUZfTE9DIChkZWYpKSAKKyAgICAgICAgICAgICAgICA/ICpERl9SRUZf UkVBTF9MT0MgKGRlZik6IERGX1JFRl9SRUcgKGRlZik7CisgICAgICBvbGQg PSBkZl9zZXRfbm90ZSAoUkVHX1VOVVNFRCwgaW5zbiwgb2xkLCByZWcpOwor I2lmZGVmIFJFR19ERUFEX0RFQlVHR0lORworICAgICAgZGZfcHJpbnRfbm90 ZSAoImFkZGluZyAzOiAiLCBpbnNuLCBSRUdfTk9URVMgKGluc24pKTsKKyNl bmRpZgorICAgIH0KICAgcmV0dXJuIG9sZDsKIH0KIApAQCAtMzk4MCwxNyAr Mzk4OSwxMyBAQCBkZl9ub3RlX2JiX2NvbXB1dGUgKHVuc2lnbmVkIGludCBi Yl9pbmRlCiAJICBmb3IgKGRlZl9yZWMgPSBERl9JTlNOX1VJRF9ERUZTICh1 aWQpOyAqZGVmX3JlYzsgZGVmX3JlYysrKQogCSAgICB7CiAJICAgICAgc3Ry dWN0IGRmX3JlZiAqZGVmID0gKmRlZl9yZWM7CisJICAgICAgLyogV2UgZG9u J3Qgd2FudCB0byBjcmVhdGUgdW51c2VkIG1hcmtlciBmb3IgY2FsbCBjbG9i YmVycy4gKi8KIAkgICAgICBpZiAoIShERl9SRUZfRkxBR1MgKGRlZikgJiAo REZfUkVGX01VU1RfQ0xPQkJFUiB8IERGX1JFRl9NQVlfQ0xPQkJFUikpKQog CQlvbGRfdW51c2VkX25vdGVzCiAJCSAgPSBkZl9jcmVhdGVfdW51c2VkX25v dGUgKGluc24sIG9sZF91bnVzZWRfbm90ZXMsIAotCQkJCQkgICBkZWYsIGxp dmUsIGRvX25vdF9nZW4sIAotCQkJCQkgICBhcnRpZmljaWFsX3VzZXMpOwot Ci0JICAgICAgLyogSG93ZXZlciBhIG1heSBvciBtdXN0IGNsb2JiZXIgc3Rp bGwgbmVlZHMgdG8ga2lsbCB0aGUKLQkJIHJlZyBzbyB0aGF0IFJFR19ERUFE IG5vdGVzIGFyZSBsYXRlciBwbGFjZWQKLQkJIGFwcHJvcHJpYXRlbHkuICAq LyAKLQkgICAgICBlbHNlIAotCQliaXRtYXBfY2xlYXJfYml0IChsaXZlLCBE Rl9SRUZfUkVHTk8gKGRlZikpOworCQkJCQkgICBkZWYsIGxpdmUsIGFydGlm aWNpYWxfdXNlcyk7CisKKwkgICAgICBkZl91cGRhdGVfbGl2ZV93aXRoX2Rl ZiAoZGVmLCBsaXZlLCBkb19ub3RfZ2VuKTsKIAkgICAgfQogCX0KICAgICAg IGVsc2UKQEAgLTQwMTMsOCArNDAxOCw5IEBAIGRmX25vdGVfYmJfY29tcHV0 ZSAodW5zaWduZWQgaW50IGJiX2luZGUKIAkgICAgICBzdHJ1Y3QgZGZfcmVm ICpkZWYgPSAqZGVmX3JlYzsKIAkgICAgICBvbGRfdW51c2VkX25vdGVzCiAJ CT0gZGZfY3JlYXRlX3VudXNlZF9ub3RlIChpbnNuLCBvbGRfdW51c2VkX25v dGVzLCAKLQkJCQkJIGRlZiwgbGl2ZSwgZG9fbm90X2dlbiwgCisJCQkJCSBk ZWYsIGxpdmUsCiAJCQkJCSBhcnRpZmljaWFsX3VzZXMpOworCSAgICAgIGRm X3VwZGF0ZV9saXZlX3dpdGhfZGVmIChkZWYsIGxpdmUsIGRvX25vdF9nZW4p OwogCSAgICB9CiAJfQogICAgICAgCkBAIC00MzkwLDUgKzQzOTYsMyBAQCBk Zl9zaW11bGF0ZV9vbmVfaW5zbl9iYWNrd2FyZHMgKGJhc2ljX2JsCiAgIGRm X3NpbXVsYXRlX3VzZXMgKGluc24sIGxpdmUpOwogICBkZl9zaW11bGF0ZV9m aXh1cF9zZXRzIChiYiwgbGl2ZSk7CiB9Ci0KLQo= ------=_Part_133412_5488993.1185472575815--