From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20794 invoked by alias); 6 Aug 2007 17:36:55 -0000 Received: (qmail 20697 invoked by uid 22791); 6 Aug 2007 17:36:54 -0000 X-Spam-Check-By: sourceware.org Received: from py-out-1112.google.com (HELO py-out-1112.google.com) (64.233.166.181) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Aug 2007 17:36:51 +0000 Received: by py-out-1112.google.com with SMTP id a29so2951629pyi for ; Mon, 06 Aug 2007 10:36:49 -0700 (PDT) Received: by 10.65.212.3 with SMTP id o3mr9269067qbq.1186421809714; Mon, 06 Aug 2007 10:36:49 -0700 (PDT) Received: by 10.64.142.18 with HTTP; Mon, 6 Aug 2007 10:36:49 -0700 (PDT) Message-ID: Date: Mon, 06 Aug 2007 17:36:00 -0000 From: "=?EUC-KR?B?U2VvbmdiYWUgUGFyayAoudq8urnoLCDa0+D328Yp?=" To: gcc-patches , "Mark Mitchell" , "Nathan Sidwell" Subject: [PATCH] Wrong line number for the closing brace of template functions MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_80319_9775355.1186421809434" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00366.txt.bz2 ------=_Part_80319_9775355.1186421809434 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 924 Hi, The included testcase in the patch demonstrates the bug, which is that the last source line of a template function was not propagated correctly to template function instances, leading to all template functions to report wrong coverage count for the implicit "return". Note that the patch is supposed to be applied on top of my previous patch: http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01953.html (Please consider this email as another ping for that patch as well) The bootstrap is done, and regtest is under way. If all tests look clean, OK for mainline ? gcc/testsuite/ChangeLog: 2007-08-06 Seongbae Park * g++.dg/gcov/gcov-5.C: New test. gcc/cp/ChangeLog: 2007-08-06 Seongbae Park * pt.c (instantiate_decl): Set input_location for the function end. -- #pragma ident "Seongbae Park, compiler, http://seongbae.blogspot.com" ------=_Part_80319_9775355.1186421809434 Content-Type: text/x-patch; name=template-end-of-func.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f518bhid Content-Disposition: attachment; filename="template-end-of-func.patch" Content-length: 2660 SW5kZXg6IGdjYy90ZXN0c3VpdGUvZysrLmRnL2djb3YvZ2Nvdi01LkMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gZ2NjL3Rlc3RzdWl0ZS9nKysuZGcv Z2Nvdi9nY292LTUuQwkocmV2aXNpb24gMCkKKysrIGdjYy90ZXN0c3VpdGUv ZysrLmRnL2djb3YvZ2Nvdi01LkMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs NTAgQEAKKy8qIENoZWNrIHRoYXQgZXhlY3V0aW9uIGNvdW50cyBmb3IgdGVt cGxhdGUgZnVuY3Rpb25zCisgICBhcmUgcmVwb3J0ZWQgY29ycmVjdGx5IGJ5 IGdjb3YuICovCisKKyNpbmNsdWRlIDxzdGRpby5oPgorI2luY2x1ZGUgPHN0 ZGxpYi5oPgorCisvKiB7IGRnLW9wdGlvbnMgIi1mcHJvZmlsZS1hcmNzIC1m dGVzdC1jb3ZlcmFnZSAtZm5vLWlubGluZSIgfSAqLworLyogeyBkZy1kbyBy dW4geyB0YXJnZXQgbmF0aXZlIH0gfSAqLworCitjbGFzcyBBIHsKKyAgaW50 IGNvdW50OworIHB1YmxpYzoKKyAgQShpbnQgYykgeyBjb3VudCA9IGM7IH0K KyAgdm9pZCBmdW5jKHZvaWQpIHsgcHJpbnRmKCJmdW5jXG4iKTsgfQorICBi b29sIGRvbmUodm9pZCkgeyAKKyAgICByZXR1cm4gKGNvdW50ID09IDApID8g dHJ1ZSA6IChjb3VudC0tICE9IDApOworICB9CisgIHZvaWQgcnVuKHZvaWQp IHsgYWJvcnQoKTsgfQorfTsKKworLy90eXBlZGVmIEEgVDsKK3RlbXBsYXRl PGNsYXNzIFQ+Cit2b2lkIFdpdGhvdXRCcmFjZShUICphKSB7CisgIHdoaWxl ICghYS0+ZG9uZSgpKSAgIAorICAgIGEtPnJ1bigpOyAgICAgICAgICAgLyog Y291bnQoIyMjIyMpICovCit9ICAgICAgICAgICAgICAgICAgICAgICAvKiBj b3VudCgxKSAqLworCit0ZW1wbGF0ZTxjbGFzcyBUPgordm9pZCBXaXRoQnJh Y2UoVCAqYSkKK3sKKyAgd2hpbGUgKCFhLT5kb25lKCkpICAgCisgICAgeyAK KyAgICAgIGEtPnJ1bigpOyAgICAgICAgIC8qIGNvdW50KCMjIyMjKSAqLwor ICAgIH0KK30gICAgICAgICAgICAgICAgICAgICAgIC8qIGNvdW50KDEpICov CisKK0EgKmZ1bmMoQSAqYSkKK3sKKyAgV2l0aG91dEJyYWNlKGEpOworICBX aXRoQnJhY2UoYSk7CisgIHJldHVybiBhOworfQorCitpbnQgbWFpbigpIHsK KyAgQSBhKDApOworICBmdW5jKCZhKTsKKyAgcmV0dXJuIDA7Cit9CisKKy8q IHsgZGctZmluYWwgeyBydW4tZ2NvdiBnY292LTUuQyB9IH0gKi8KSW5kZXg6 IGdjYy9jcC9wdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9j cC9wdC5jCShyZXZpc2lvbiAxMjcyNDYpCisrKyBnY2MvY3AvcHQuYwkod29y a2luZyBjb3B5KQpAQCAtMTQ0MzgsNiArMTQ0MzgsMTIgQEAgaW5zdGFudGlh dGVfZGVjbCAodHJlZSBkLCBpbnQgZGVmZXJfb2ssCiAJCSAgIHRmX3dhcm5p bmdfb3JfZXJyb3IsIHRtcGwsCiAJCSAgIC8qaW50ZWdyYWxfY29uc3RhbnRf ZXhwcmVzc2lvbl9wPSovZmFsc2UpOwogCisgICAgICAvKiBNYWtlIHN1cmUg dGhlIGN1cnJlbnQgaW5wdXRfbG9jYXRpb24KKyAgICAgICAgIGlzIHNldCBj b3JyZWN0bHkgdG8gdGhlIGVuZCBvZiB0aGUgZnVuY3Rpb24KKwkgLSB0aGlz IG1ha2VzIGZpbmlzaF9mdW5jdGlvbiB0byBzZXQKKwkgZnVuY3Rpb25fZW5k X2xvY3VzIG9mIHRoaXMgc3BlY2lhbGl6YXRpb24gY29ycmVjdGx5LiAqLwor ICAgICAgaW5wdXRfbG9jYXRpb24gPSBERUNMX1NUUlVDVF9GVU5DVElPTiAo Y29kZV9wYXR0ZXJuKS0+ZnVuY3Rpb25fZW5kX2xvY3VzOworCiAgICAgICAv KiBXZSBkb24ndCBuZWVkIHRoZSBsb2NhbCBzcGVjaWFsaXphdGlvbnMgYW55 IG1vcmUuICAqLwogICAgICAgaHRhYl9kZWxldGUgKGxvY2FsX3NwZWNpYWxp emF0aW9ucyk7CiAgICAgICBsb2NhbF9zcGVjaWFsaXphdGlvbnMgPSBzYXZl ZF9sb2NhbF9zcGVjaWFsaXphdGlvbnM7Cg== ------=_Part_80319_9775355.1186421809434--