From: Bernd Schmidt <bschmidt@redhat.com>
To: vogt@linux.vnet.ibm.com, Jeff Law <law@redhat.com>,
gcc-patches@gcc.gnu.org,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2][v3] Drop excess size used for run time allocated stack variables.
Date: Wed, 08 Jun 2016 11:21:00 -0000 [thread overview]
Message-ID: <abc09267-bee9-fa7b-ab2b-dd041bbdf907@redhat.com> (raw)
In-Reply-To: <20160525133241.GB6938@linux.vnet.ibm.com>
On 05/25/2016 03:32 PM, Dominik Vogt wrote:
> * explow.c (round_push): Use know adjustment.
> (allocate_dynamic_stack_space): Pass known adjustment to round_push.
> gcc/testsuite/ChangeLog
>
I was thinking about whether it would be possible/desirable to eliminate
the double add entirely, but I couldn't find a way to structure the code
in a way that seems better than what you have. So, ...
> /* Round the size of a block to be pushed up to the boundary required
> - by this machine. SIZE is the desired size, which need not be constant. */
> + by this machine. SIZE is the desired size, which need not be constant.
> + ALREADY_ADDED is the number of units that have already been added to SIZE
> + for other alignment reasons.
> +*/
The */ goes on the last line of the comment.
> +/* PR/50938: Check that alloca () reserves the correct amount of stack space.
> + */
Same here really, even if it's only a test.
Ok with these fixed.
Bernd
next prev parent reply other threads:[~2016-06-08 11:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 22:13 [PATCH] " Dominik Vogt
2016-04-29 22:15 ` Dominik Vogt
2016-04-30 9:44 ` Eric Botcazou
2016-04-30 10:14 ` Dominik Vogt
2016-05-02 13:43 ` Dominik Vogt
2016-05-02 15:10 ` Jeff Law
2016-05-03 14:18 ` Dominik Vogt
2016-05-19 23:11 ` Jeff Law
2016-05-20 21:24 ` [RFA] Minor cleanup to allocate_dynamic_stack_space Jeff Law
2016-05-20 21:44 ` Eric Botcazou
2016-05-20 21:48 ` Jeff Law
2016-05-23 7:53 ` Eric Botcazou
2016-05-23 10:12 ` Dominik Vogt
2016-05-25 12:46 ` Dominik Vogt
2016-06-09 12:00 ` [PATCH] Drop excess size used for run time allocated stack variables Bernd Schmidt
2016-06-21 9:35 ` Dominik Vogt
2016-06-21 22:26 ` Jeff Law
2016-06-22 8:57 ` Dominik Vogt
2016-05-25 14:02 ` [PATCH 1/2][v3] " Dominik Vogt
2016-05-25 14:31 ` [PATCH 2/2][v3] " Dominik Vogt
2016-05-25 14:51 ` Dominik Vogt
2016-06-08 11:21 ` Bernd Schmidt [this message]
2016-06-20 12:20 ` Dominik Vogt
2016-06-20 12:20 ` Bernd Schmidt
2016-06-23 4:24 ` Jeff Law
2016-06-23 9:57 ` Dominik Vogt
2016-07-21 20:07 ` Jeff Law
2016-07-22 12:02 ` Dominik Vogt
2016-07-26 15:53 ` [PATCH 2/2][v4] " Dominik Vogt
2016-08-18 16:20 ` Jeff Law
2016-08-23 9:23 ` Andreas Krebbel
2016-06-08 11:20 ` [PATCH 1/2][v3] " Bernd Schmidt
2016-06-08 12:20 ` Eric Botcazou
2016-06-22 20:34 ` Jeff Law
2016-07-04 14:22 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc09267-bee9-fa7b-ab2b-dd041bbdf907@redhat.com \
--to=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=law@redhat.com \
--cc=vogt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).