From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 259E13858C52 for ; Fri, 12 Aug 2022 11:03:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 259E13858C52 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27CAmp3M006646 for ; Fri, 12 Aug 2022 11:03:37 GMT Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hwnebrbjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 11:03:37 +0000 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27CAuLRu023268 for ; Fri, 12 Aug 2022 11:03:35 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma02fra.de.ibm.com with ESMTP id 3huww0tj8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 11:03:35 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27CB3W8928115384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Aug 2022 11:03:32 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C026AE057; Fri, 12 Aug 2022 11:03:32 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 022C1AE055; Fri, 12 Aug 2022 11:03:32 +0000 (GMT) Received: from [9.171.46.216] (unknown [9.171.46.216]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 12 Aug 2022 11:03:31 +0000 (GMT) Message-ID: Date: Fri, 12 Aug 2022 13:03:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: GCC Patches , Andreas Krebbel From: Robin Dapp Subject: [PATCH] s390: Implement vec_revb(vector short)/bswapv8hi with, verllh. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: dTZrwC5ubYRdqjF1133Qzc9xADeD8h2T X-Proofpoint-GUID: dTZrwC5ubYRdqjF1133Qzc9xADeD8h2T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-12_08,2022-08-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208120029 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2022 11:03:39 -0000 Hi, this patch implements a byte swap for a V8HImode vector via an element rotate by 8 bits. Bootstrapped and regtested, no regressions. Is it OK? Regards Robin gcc/ChangeLog: PR target/100867 * config/s390/vector.md: Add special case for V8HImode. gcc/testsuite/ChangeLog: * gcc.target/s390/zvector/vec-revb-short.c: New test. --- gcc/config/s390/vector.md | 35 ++++++++++++------- .../gcc.target/s390/zvector/vec-revb-short.c | 13 +++++++ 2 files changed, 35 insertions(+), 13 deletions(-) create mode 100644 gcc/testsuite/gcc.target/s390/zvector/vec-revb-short.c diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md index 2207f39b80e4..6f46bed03e00 100644 --- a/gcc/config/s390/vector.md +++ b/gcc/config/s390/vector.md @@ -2898,22 +2898,31 @@ (define_expand "bswap" for (int i = 0; i < 16; i++) perm_rtx[i] = GEN_INT (perm[i]); - operands[2] = gen_rtx_CONST_VECTOR (V16QImode, gen_rtvec_v (16, perm_rtx)); - - /* Without vxe2 we do not have byte swap instructions dealing - directly with memory operands. So instead of waiting until - reload to fix that up switch over to vector permute right - now. */ - if (!TARGET_VXE2) + if (!TARGET_VXE2 && mode == V8HImode) { - rtx in = force_reg (V16QImode, simplify_gen_subreg (V16QImode, operands[1], mode, 0)); - rtx permute = force_reg (V16QImode, force_const_mem (V16QImode, operands[2])); - rtx out = gen_reg_rtx (V16QImode); - - emit_insn (gen_vec_permv16qi (out, in, in, permute)); - emit_move_insn (operands[0], simplify_gen_subreg (mode, out, V16QImode, 0)); + /* A byte swap for a short is just a rotate by 8 bits. */ + emit_insn (gen_rotlv8hi3 (operands[0], operands[1], GEN_INT (8))); DONE; } + else + { + operands[2] = gen_rtx_CONST_VECTOR (V16QImode, gen_rtvec_v (16, perm_rtx)); + + /* Without vxe2 we do not have byte swap instructions dealing + directly with memory operands. So instead of waiting until + reload to fix that up switch over to vector permute right + now. */ + if (!TARGET_VXE2) + { + rtx in = force_reg (V16QImode, simplify_gen_subreg (V16QImode, operands[1], mode, 0)); + rtx permute = force_reg (V16QImode, force_const_mem (V16QImode, operands[2])); + rtx out = gen_reg_rtx (V16QImode); + + emit_insn (gen_vec_permv16qi (out, in, in, permute)); + emit_move_insn (operands[0], simplify_gen_subreg (mode, out, V16QImode, 0)); + DONE; + } + } }) ; Switching late to the reg-reg variant requires the vector permute diff --git a/gcc/testsuite/gcc.target/s390/zvector/vec-revb-short.c b/gcc/testsuite/gcc.target/s390/zvector/vec-revb-short.c new file mode 100644 index 000000000000..bf58a0e12e74 --- /dev/null +++ b/gcc/testsuite/gcc.target/s390/zvector/vec-revb-short.c @@ -0,0 +1,13 @@ +/* Test that we use verllh for byte reversing a vector of shorts. */ +/* { dg-do compile { target { s390*-*-* } } } */ +/* { dg-options "-O2 -march=z13 -mzvector -mzarch -fno-unroll-loops" } */ + +/* { dg-final { scan-assembler-times "verllh\t" 1 } } */ +/* { dg-final { scan-assembler-not "vperm" } } */ + +#include + +vector short revb (vector short a) +{ + return vec_revb (a); +} -- 2.31.1