Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks.

[Sandra Loosemore <sandra@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On 11/10/21 11:53 AM, Tamar Christina wrote:
> FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized 
> "[file://\\s+]\\s+>\\s+{ 0,
> 0, 0, 0 }" 1
> 
> That's the old test which this patch has changed. Does it still fail 
> with the new patch?

My test results are indeed from a couple days ago.  But, I looked at 
your new modifications to this test, and still don't see anything like 
the pattern it's looking for, or understand what output you expect to be 
happening here.  Is the whole test specific to vector ISAs, and not just 
your recent changes to it?  I've attached the .optimized dump I got on 
nios2-elf.

-Sandra

[-- Attachment #2: signbit-2.c.250t.optimized --]
[-- Type: text/plain, Size: 2028 bytes --]


;; Function fun1 (fun1, funcdef_no=0, decl_uid=1561, cgraph_uid=1, symbol_order=0)

Removing basic block 6
Removing basic block 7
Removing basic block 8
void fun1 (int32_t * x, int n)
{
  unsigned int ivtmp.11;
  long int _4;
  long int _6;
  unsigned int _9;
  _Bool _15;
  unsigned int _16;
  int _17;
  unsigned int _21;
  long int _22;
  void * _23;

  <bb 2> [local count: 118111600]:
  _17 = n_11(D) & -16;
  if (_17 > 0)
    goto <bb 3>; [89.00%]
  else
    goto <bb 5>; [11.00%]

  <bb 3> [local count: 105119324]:
  ivtmp.11_24 = (unsigned int) x_12(D);
  _21 = (unsigned int) _17;
  _16 = _21 * 4;
  _9 = _16 + ivtmp.11_24;

  <bb 4> [local count: 955630225]:
  # ivtmp.11_20 = PHI <ivtmp.11_25(4), ivtmp.11_24(3)>
  _23 = (void *) ivtmp.11_20;
  _4 = MEM[(int32_t *)_23];
  _15 = _4 > 0;
  _22 = (long int) _15;
  _6 = -_22;
  MEM[(int32_t *)_23] = _6;
  ivtmp.11_25 = ivtmp.11_20 + 4;
  if (_9 != ivtmp.11_25)
    goto <bb 4>; [89.00%]
  else
    goto <bb 5>; [11.00%]

  <bb 5> [local count: 118111600]:
  return;

}



;; Function fun2 (fun2, funcdef_no=1, decl_uid=1570, cgraph_uid=2, symbol_order=1)

Removing basic block 6
Removing basic block 7
Removing basic block 8
void fun2 (int32_t * x, int n)
{
  unsigned int ivtmp.19;
  long int _4;
  long int _5;
  long int _6;
  unsigned int _9;
  unsigned int _16;
  int _17;
  unsigned int _21;
  void * _23;

  <bb 2> [local count: 118111600]:
  _17 = n_11(D) & -16;
  if (_17 > 0)
    goto <bb 3>; [89.00%]
  else
    goto <bb 5>; [11.00%]

  <bb 3> [local count: 105119324]:
  ivtmp.19_24 = (unsigned int) x_12(D);
  _21 = (unsigned int) _17;
  _16 = _21 * 4;
  _9 = _16 + ivtmp.19_24;

  <bb 4> [local count: 955630225]:
  # ivtmp.19_20 = PHI <ivtmp.19_25(4), ivtmp.19_24(3)>
  _23 = (void *) ivtmp.19_20;
  _4 = MEM[(int32_t *)_23];
  _5 = -_4;
  _6 = _5 >> 30;
  MEM[(int32_t *)_23] = _6;
  ivtmp.19_25 = ivtmp.19_20 + 4;
  if (_9 != ivtmp.19_25)
    goto <bb 4>; [89.00%]
  else
    goto <bb 5>; [11.00%]

  <bb 5> [local count: 118111600]:
  return;

}