From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 6E2A33858D35 for ; Wed, 10 Nov 2021 20:03:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E2A33858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 902E4Fbpja5V63figGh/Ygjyxtq7kzftlriAYV4I9RSL9s1dSryTPdZO9RKmN00Nm6ZNyZCJYf Bsm0XHVWTpsZSy+Ytjo/fnIcFQ9Sg5zy+XMIPeuryKk5U7B0gRe9Vh/6lWjVCFUN/5BwJEUjNm 1eHE0eYMAJIJJ+1Sv0IyepjYtAY4fzZBAVyDZC/eoU8XnB0WvnQj9g4LEgDPN4l34SQvWqFxq7 yJmI1zt7xxhzCgnkQFkv5HNHhleLpHjnX6NwcLpWBclCfzEjYp5D7pmfAQBK3jVIXy7X7l/wVp ipt/d0ueP73Ku/3GLYiKpCZu X-IronPort-AV: E=Sophos;i="5.87,224,1631606400"; d="scan'208";a="70789347" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 10 Nov 2021 12:03:07 -0800 IronPort-SDR: qmOz9SHusgA7kEwn1HeZL7opEXJBo3OHBIBVU95ZbJHBzzmMEdvNkChETBT46RqlUbUhTL48KC ad3FQFh5AUsQnXGKl6oM4Gw5F9nYGF32gFs5lbISWxdAODyVzXNSfiieMAOPFVWoj2MPv0M3/F FZZAlXXXEtV/L9SwRQ53pzH7vTo/XIsPUGaLE/kKS9dhWDqfmJUwB8+uQ0nk4zm+uEkJggck28 fpSmShiLgY+b5fc8wK21N3YSMDyRnzlgMEstGPdtiJOc3ZqKRR7WeTAY4Iqi79qbT8/ASgJ1ed vFU= Subject: Re: [PATCH][committed]middle-end: Fix signbit tests when ran on ISA with support for masks. To: Tamar Christina , "gcc-patches@gcc.gnu.org" CC: nd , "rguenther@suse.de" References: <617e70fb-7250-d599-bf38-41899ed99e5c@codesourcery.com> From: Sandra Loosemore Message-ID: Date: Wed, 10 Nov 2021 13:03:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------1457851B3E4E9ED30469E967" Content-Language: en-US X-ClientProxiedBy: SVR-ORW-MBX-07.mgc.mentorg.com (147.34.90.207) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 20:03:09 -0000 --------------1457851B3E4E9ED30469E967 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 11/10/21 11:53 AM, Tamar Christina wrote: > FAIL: gcc.dg/signbit-2.c scan-tree-dump-times optimized > "[file://\\s+]\\s+>\\s+{ 0, > 0, 0, 0 }" 1 > > That's the old test which this patch has changed. Does it still fail > with the new patch? My test results are indeed from a couple days ago. But, I looked at your new modifications to this test, and still don't see anything like the pattern it's looking for, or understand what output you expect to be happening here. Is the whole test specific to vector ISAs, and not just your recent changes to it? I've attached the .optimized dump I got on nios2-elf. -Sandra --------------1457851B3E4E9ED30469E967 Content-Type: text/plain; charset="UTF-8"; name="signbit-2.c.250t.optimized" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signbit-2.c.250t.optimized" ;; Function fun1 (fun1, funcdef_no=0, decl_uid=1561, cgraph_uid=1, symbol_order=0) Removing basic block 6 Removing basic block 7 Removing basic block 8 void fun1 (int32_t * x, int n) { unsigned int ivtmp.11; long int _4; long int _6; unsigned int _9; _Bool _15; unsigned int _16; int _17; unsigned int _21; long int _22; void * _23; [local count: 118111600]: _17 = n_11(D) & -16; if (_17 > 0) goto ; [89.00%] else goto ; [11.00%] [local count: 105119324]: ivtmp.11_24 = (unsigned int) x_12(D); _21 = (unsigned int) _17; _16 = _21 * 4; _9 = _16 + ivtmp.11_24; [local count: 955630225]: # ivtmp.11_20 = PHI _23 = (void *) ivtmp.11_20; _4 = MEM[(int32_t *)_23]; _15 = _4 > 0; _22 = (long int) _15; _6 = -_22; MEM[(int32_t *)_23] = _6; ivtmp.11_25 = ivtmp.11_20 + 4; if (_9 != ivtmp.11_25) goto ; [89.00%] else goto ; [11.00%] [local count: 118111600]: return; } ;; Function fun2 (fun2, funcdef_no=1, decl_uid=1570, cgraph_uid=2, symbol_order=1) Removing basic block 6 Removing basic block 7 Removing basic block 8 void fun2 (int32_t * x, int n) { unsigned int ivtmp.19; long int _4; long int _5; long int _6; unsigned int _9; unsigned int _16; int _17; unsigned int _21; void * _23; [local count: 118111600]: _17 = n_11(D) & -16; if (_17 > 0) goto ; [89.00%] else goto ; [11.00%] [local count: 105119324]: ivtmp.19_24 = (unsigned int) x_12(D); _21 = (unsigned int) _17; _16 = _21 * 4; _9 = _16 + ivtmp.19_24; [local count: 955630225]: # ivtmp.19_20 = PHI _23 = (void *) ivtmp.19_20; _4 = MEM[(int32_t *)_23]; _5 = -_4; _6 = _5 >> 30; MEM[(int32_t *)_23] = _6; ivtmp.19_25 = ivtmp.19_20 + 4; if (_9 != ivtmp.19_25) goto ; [89.00%] else goto ; [11.00%] [local count: 118111600]: return; } --------------1457851B3E4E9ED30469E967--