public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: Jeff Law <law@redhat.com>, Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] fix integer overflow bugs in gimple-ssa-sprintf.c (PR 78608)
Date: Tue, 17 Jan 2017 00:24:00 -0000	[thread overview]
Message-ID: <ac1a9bca-04bc-6a0c-d53d-8afa1d22b970@gmail.com> (raw)
In-Reply-To: <ce4c16d3-9b4c-55d3-4b6d-192b590fd341@redhat.com>

> If the FIXME was a future thing, then this is OK with the nits fixed. If
> the FIXME was a marker for something you intended to address now and
> just forgot, then we either need another iteration or a follow-up patch
> depending on the severity of the FIXME in your  mind.

As we discussed privately, I went ahead and committed just a minimal
patch to resolve the bug in r244511.  Most of the rest of the changes
in the patch have either already been made to resolve other bugs or
are a part of the bigger patch for bug 78703 that's under review.

I wanted to resolve the bug without making merging the bigger patch
harder than it needs to be.

Thanks
Martin

      parent reply	other threads:[~2017-01-17  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03  0:36 Martin Sebor
2016-12-13 23:49 ` Martin Sebor
2016-12-14  0:25   ` Jeff Law
2016-12-14  6:08 ` Jeff Law
2016-12-14 16:43   ` Martin Sebor
2016-12-19 22:34     ` Jeff Law
2017-01-17  0:24   ` Martin Sebor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac1a9bca-04bc-6a0c-d53d-8afa1d22b970@gmail.com \
    --to=msebor@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).