From: Jeff Law <law@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>, Gerald Pfeifer <gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] implement generic debug() for vectors and hash sets
Date: Mon, 27 Nov 2017 17:33:00 -0000 [thread overview]
Message-ID: <ac685a56-cdf6-cdb3-7326-2ce16825f4a2@redhat.com> (raw)
In-Reply-To: <2ed5320b-aa44-51fc-0543-fdcbfbd478e5@redhat.com>
On 11/27/2017 08:03 AM, Aldy Hernandez wrote:
>
>
> On 11/23/2017 02:12 PM, Gerald Pfeifer wrote:
>> On Tue, 21 Nov 2017, Gerald Pfeifer wrote:
>>> /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit
>>> instantiation cannot have a storage class
>>> DEFINE_DEBUG_VEC (rtx_def *)
>>> ^
>>> /scratch/tmp/gerald/GCC-HEAD/gcc/vec.h:456:24: note: expanded from
>>> macro 'DEFINE_DEBUG_VEC'
>>> Â Â template static void debug_helper (vec<T> &);Â Â Â Â Â Â Â Â \
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ^
>>>
>>> The first failing boostrap seems to have been yesterday at 16:40 UTC,
>>> 24 hours before it still worked.
>>
>> This fixes it for me; bootstrapped&tested on i586-unknown-freebsd10.4
>> (and compared with the last successbuild on the 19th).
>
> Sorry for dropping the ball on this over the US holidays.
>
> This looks good to me, though I can't approve.
>
> Thanks.
>
>>
>> Okay?
>>
>> Gerald
>>
>>
>> 2017-11-23 Gerald Pfeifer <gerald@pfeifer.com>
>>
>> Â Â Â Â * hash-set.h (DEFINE_DEBUG_HASH_SET): Remove static qualifier
>> Â Â Â Â from explicit instantiation of debug_helper.
>> Â Â Â Â * vec.h (DEFINE_DEBUG_VEC): Ditto.
OK. I must have missed this...
jeff
next prev parent reply other threads:[~2017-11-27 17:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 13:56 Aldy Hernandez
2017-10-16 14:47 ` Aldy Hernandez
2017-10-23 9:49 ` PING Fwd: " Aldy Hernandez
2017-11-19 22:56 ` Jeff Law
2017-11-20 11:57 ` Aldy Hernandez
2017-11-21 11:33 ` Gerald Pfeifer
2017-11-21 12:46 ` Aldy Hernandez
2017-11-21 13:35 ` Gerald Pfeifer
2017-11-23 19:32 ` Gerald Pfeifer
2017-11-27 15:18 ` Aldy Hernandez
2017-11-27 17:33 ` Jeff Law [this message]
2018-02-12 21:31 ` PING Fwd: " Jason Merrill
2017-11-13 8:46 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac685a56-cdf6-cdb3-7326-2ce16825f4a2@redhat.com \
--to=law@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).