From: John Tytgat <John.Tytgat@aaug.net>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, ARM] Fix PR45094
Date: Sun, 01 Aug 2010 12:38:00 -0000 [thread overview]
Message-ID: <ac8cf73f51.Jo@hobbes.bass-software.com> (raw)
In-Reply-To: <20100801083614.GA2569@qiyaows>
In message <20100801083614.GA2569@qiyaows>
Yao Qi <yao@codesourcery.com> wrote:
> This patch fixes generated wrong instructions reported in PR45094,
> which is caused by typo.
>
> Tested on arm-unknown-linux-gnueabi, fixes the new test.
> [...]
> Index: config/arm/arm.c
> ===================================================================
> --- config/arm/arm.c (revision 162792)
> +++ config/arm/arm.c (working copy)
> @@ -12570,13 +12570,13 @@
> {
> if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY)
> {
> - output_asm_insn ("ldr%?\t%0, [%1, %2]!", otherops);
> - output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops);
> + output_asm_insn ("str%?\t%0, [%1, %2]!", otherops);
> + output_asm_insn ("strr%?\t%H0, [%1, #4]", otherops);
^^^
Typo (one 'r') ?
> }
> else
> {
> - output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops);
> - output_asm_insn ("ldr%?\t%0, [%1], %2", otherops);
> + output_asm_insn ("str%?\t%H0, [%1, #4]", otherops);
> + output_asm_insn ("str%?\t%0, [%1], %2", otherops);
> }
> }
> else if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY)
John.
--
John Tytgat, in his comfy chair at home
John.Tytgat@aaug.net
next prev parent reply other threads:[~2010-08-01 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 8:36 Yao Qi
2010-08-01 12:38 ` John Tytgat [this message]
2010-08-01 14:58 ` Yao Qi
2010-08-02 0:38 ` Daniel Jacobowitz
2010-08-03 13:29 ` Yao Qi
2010-08-03 23:58 ` Ramana Radhakrishnan
2010-08-04 4:18 ` Yao Qi
2010-08-04 12:52 ` Ramana Radhakrishnan
2010-08-10 13:16 ` [PING] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8cf73f51.Jo@hobbes.bass-software.com \
--to=john.tytgat@aaug.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).