From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30089 invoked by alias); 1 Aug 2010 12:38:36 -0000 Received: (qmail 30079 invoked by uid 22791); 1 Aug 2010 12:38:35 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from eir.is.scarlet.be (HELO eir.is.scarlet.be) (193.74.71.27) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Aug 2010 12:38:30 +0000 Received: from hobbes (ip-83-134-145-239.dsl.scarlet.be [83.134.145.239]) by eir.is.scarlet.be (8.14.2/8.14.2) with ESMTP id o71CcReu028104 for ; Sun, 1 Aug 2010 14:38:28 +0200 Date: Sun, 01 Aug 2010 12:38:00 -0000 From: John Tytgat To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] Fix PR45094 Message-ID: References: <20100801083614.GA2569@qiyaows> In-Reply-To: <20100801083614.GA2569@qiyaows> X-Organization: BASS User-Agent: Messenger-Pro/2.62 (MsgServe/2.05) (RISC-OS/6.21) POPstar/2.05 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-DCC-scarlet.be-Metrics: eir 20002; Body=1 Fuz1=1 Fuz2=1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-08/txt/msg00012.txt.bz2 In message <20100801083614.GA2569@qiyaows> Yao Qi wrote: > This patch fixes generated wrong instructions reported in PR45094, > which is caused by typo. > > Tested on arm-unknown-linux-gnueabi, fixes the new test. > [...] > Index: config/arm/arm.c > =================================================================== > --- config/arm/arm.c (revision 162792) > +++ config/arm/arm.c (working copy) > @@ -12570,13 +12570,13 @@ > { > if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY) > { > - output_asm_insn ("ldr%?\t%0, [%1, %2]!", otherops); > - output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops); > + output_asm_insn ("str%?\t%0, [%1, %2]!", otherops); > + output_asm_insn ("strr%?\t%H0, [%1, #4]", otherops); ^^^ Typo (one 'r') ? > } > else > { > - output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops); > - output_asm_insn ("ldr%?\t%0, [%1], %2", otherops); > + output_asm_insn ("str%?\t%H0, [%1, #4]", otherops); > + output_asm_insn ("str%?\t%0, [%1], %2", otherops); > } > } > else if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY) John. -- John Tytgat, in his comfy chair at home John.Tytgat@aaug.net