From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 781803858C3A for ; Mon, 16 Oct 2023 19:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 781803858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 781803858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697483572; cv=none; b=AROs0l5KFKutXh5wOvzfJ5YKPhdKENyciiDHwkjJgvllpn1p7YcEd6obmKMzUmFNScwL3TFd5U27oYcZ9jLdlb7nGkSsF+RDQEtUR1eAyYDsLMsvfixU4e/M2jRqp8Spn+yzLkYV+mxxGprISxTFX2CIyZu2LoTGWhslcBc11T0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697483572; c=relaxed/simple; bh=yWD+P9+d3m4Z83R5je0jHoYxRblECcCeWf3snbWakqg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EUTVPLILZKT/Sa1196aAQUgw79NwqYRRr7VnHFPobR6N5TKzoc05qaIzINWzZ07YtKGROtDcc4sG8HqxdZ/p2O5yUDvNE+esclfYHaEZ1dO1MfjeS02eRSdI6moEA+XNZs/th0sM7NJ59X8rWZ1Uj2i681JGNB+qu7b8tps6CNo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6b87c1edfd5so1949546b3a.1 for ; Mon, 16 Oct 2023 12:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697483568; x=1698088368; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NBts4rBmZdUJ64zRgOGTg+rDY9zcWQXB2rIjiBRgvGM=; b=Ywcyn6SerPmP4EbCM6x0rtsS4V47TKyL74tEP77mVkwBaznjJ0nUv5Akz7BP36I9tH o2i2z1F90KqYBYz8g7OvTrbjiFlxWvXJ3R7lypxwwbak6A81wG2XC4j5VSp63OTlRyxj G7FYizceQS/qli4CDfz1n7G/l0i8IddZn8ASEMPMFVUj0Ejlxq6TIZByaV+NyORP4PyD e+QKzSgPbfLS1Mrd+uy6h53tpK8tFr4TtF5rXMaWnP23lOILBsVCYEAJkZ8cuzSIHZg+ BjM/K+qu85wmhBrG8P0hvMc7qzzSTE8/oL3U8yT1eTEf3wYnCsRB4P+sOy4F4dyka6Mn hSrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697483568; x=1698088368; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NBts4rBmZdUJ64zRgOGTg+rDY9zcWQXB2rIjiBRgvGM=; b=FTfOzOTUajXFysooh+sP757l7IqX7SOutXA7MuiiCRvh6qNStYg9kZ0IzLx7ZEiErx zB8ghVaC72Zklv+2VsU3Xjpjce4KXGQyk6zmAIJ3URXK2YZleOQbo1y0CoTSU9ENWVf7 pwNYNNiANqWGyOMQ2JmDvFjAhPrmxhhqI+RocZPQr414dq4To85RKSnZ39JbDfuKwuin iRuFfWI3SfFo64HVDKD1vzKEv7OR+YuBszmTYQbYhbfpTDpOKAkgNZVx+UJY7scoE8E3 MzUsPsoopbeNmM2BmFEHIOD1bP0U9E0bsaAxbHYUbWJssuhiPcOn2QdIFdItjTnLf+t0 RXwA== X-Gm-Message-State: AOJu0YzIaho4FnqcF8WF3khtcBl+i3N/OJKj9Met8zEI0pDjbc4e/TU3 sEDAlPFoNwM3ObVlDV0oKMY= X-Google-Smtp-Source: AGHT+IHQUTbqC6hBftupKL4ljoh+raNgX80U+m1rA7+1O6L7RNlz4HIawXhgNuZjTWCdXAqxgwD/3g== X-Received: by 2002:a05:6a00:c91:b0:6be:43d5:6505 with SMTP id a17-20020a056a000c9100b006be43d56505mr105052pfv.6.1697483568287; Mon, 16 Oct 2023 12:12:48 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ka38-20020a056a0093a600b006b3b342f37fsm255836pfb.178.2023.10.16.12.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 12:12:47 -0700 (PDT) Message-ID: Date: Mon, 16 Oct 2023 13:12:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V/testsuite: add a default march (lacking zfa) to some fp tests Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Palmer Dabbelt , gnu-toolchain@rivosinc.com, "Maciej W . Rozycki" References: <20231015181644.886680-1-vineetg@rivosinc.com> From: Jeff Law In-Reply-To: <20231015181644.886680-1-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/15/23 12:16, Vineet Gupta wrote: > A bunch of FP tests expecting specific FP asm output fail when built > with zfa because different insns are generated. And this happens > because those tests don't have an explicit -march and the default > used to configure gcc could end up with zfa causing the false fails. > > Fix that by adding the -march explicitly which doesn't have zfa. > > BTW it seems we have some duplication in tests for zfa and non-zfa and > it would have been better if they were consolidated, but oh well. > > gcc/testsuite: > * gcc.target/riscv/fle-ieee.c: Updates dg-options with > explicit -march=rv64gc and -march=rv43gc. > * gcc.target/riscv/fle-snan.c: Ditto. > * gcc.target/riscv/fle.c: Ditto. > * gcc.target/riscv/flef-ieee.c: Ditto. > * gcc.target/riscv/flef.c: Ditto. > * gcc.target/riscv/flef-snan.c: Ditto. > * gcc.target/riscv/flt-ieee.c: Ditto. > * gcc.target/riscv/flt-snan.c: Ditto. > * gcc.target/riscv/fltf-ieee.c: Ditto. > * gcc.target/riscv/fltf-snan.c: Ditto. > > Signed-off-by: Vineet Gupta OK with the "rv43" -> "rv32" typo fixed in the ChangeLog. Jeff