Re: [Committed] testsuite: Add support for scanning assembly with comparitor

[Edwin Lu <ewlu@rivosinc.com>]

Thanks! Committed

Edwin

On 2/15/2024 9:27 AM, Mike Stump wrote:
> On Feb 12, 2024, at 11:38 AM, Edwin Lu <ewlu@rivosinc.com> wrote:
>> There is currently no support for matching at least x lines of assembly
>> (only scan-assembler-times). This patch would allow setting upper or lower
>> bounds.
>>
>> Use case: using different scheduler descriptions and/or cost models will change
>> assembler output. Testing common functionality across tunes would require a
>> separate testcase per tune since each assembly output would be different. If we
>> know a base number of lines should appear across all tunes (i.e. testing return
>> values: we expect at minimum n stores into register x), we can lower-bound the
>> test to search for scan-assembler-bound {RE for storing into register x} >= n.
>> This avoids artificially inflating the scan-assembler-times expected count due
>> to the assembler choosing to perform extra stores into register x (using it as
>> a temporary register).
>>
>> The testcase would be more robust to cpu/tune changes at the cost of not being
>> as granular towards specific cpu tuning.
> I didn't see an Ok?  Just in case you forgot, yes, this is ok.